Add ability to profile app start up and improve CPU profile caching #3357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacob314
reviewed
Sep 13, 2021
| @@ -114,6 +115,8 @@ class IconLabelButton extends StatelessWidget { | |||
|
|
|||
| final String tooltip; | |||
|
|
|||
| final EdgeInsetsGeometry tooltipPadding; | |||
There was a problem hiding this comment.
why is this needed? Is there a reason we can't just give all tooltips a reasonable default?
There was a problem hiding this comment.
Multiline tooltips will look bad without specifying the padding. Single line tooltips have adequate spacing on the top and bottom, but if there is a new line char in the tooltip message, that top and bottom spacing disappears.
jacob314
reviewed
Sep 13, 2021
packages/devtools_app/lib/src/profiler/cpu_profile_controller.dart
Outdated
Show resolved
Hide resolved
jacob314
reviewed
Sep 13, 2021
packages/devtools_app/lib/src/profiler/cpu_profile_controller.dart
Outdated
Show resolved
Hide resolved
jacob314
reviewed
Sep 13, 2021
packages/devtools_app/lib/src/profiler/cpu_profile_controller.dart
Outdated
Show resolved
Hide resolved
jacob314
reviewed
Sep 13, 2021
packages/devtools_app/lib/src/profiler/cpu_profile_controller.dart
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards #2982. We will still use the DDS apis once they are available.
When an app start up profile is available, clicking this button will load the profile and automatically select the AppStartUp usertag:
When an app start up profile is not available, a warning message will be displayed. The default profiling rate may cause this case to occur more often than we like. See flutter/flutter#84884 (comment) for some more details.
The PR also fixes #3317 and improves the caching for the CPU profiler in general. This will prevent duplicate processing actions when a user is changing filters back and forth. This also fixes bugs where the filters were not applied correctly to profiles cached by user tag.