Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cleanup] Merge InspectorTreeControllerFlutter and superclass into single InspectorTreeController class #3367

Merged
merged 6 commits into from Sep 16, 2021
Merged

[Cleanup] Merge InspectorTreeControllerFlutter and superclass into single InspectorTreeController class #3367

merged 6 commits into from Sep 16, 2021

Conversation

matt-ragonese
Copy link
Contributor

Previously, InspectorTreeControllerFlutter implemented the InspectorTreeController abstract class and InspectorTreeFixedRowHeightController mixin.

This change merges these three classes/mixins into a single InspectorTreeController class.

@matt-ragonese matt-ragonese marked this pull request as ready for review September 16, 2021 17:01
jacob314
jacob314 approved these changes Sep 16, 2021
View reviewed changes
Copy link
Contributor

@jacob314 jacob314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
Good to land once the bots go green.
Thanks for cleaning this up.

@jacob314 jacob314 merged commit ecbd129 into flutter:master Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacob314 jacob314 jacob314 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matt-ragonese @jacob314