Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cleanup] Merge InspectorTreeControllerFlutter and superclass into single InspectorTreeController class #3367

Merged
merged 6 commits into from Sep 16, 2021
Merged

[Cleanup] Merge InspectorTreeControllerFlutter and superclass into single InspectorTreeController class #3367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
1a5ce1e
Rename InspectorTreeController to InspectorTreeControllerBase
matt-ragonese Sep 14, 2021
75edede
Moved InspectorTreeControllerBase and InspectorTreeFixedRowHeightCont…
matt-ragonese Sep 15, 2021
2bf4607
Renamed inspector_tree_flutter.dart to inspector_tree_controller.dart
matt-ragonese Sep 15, 2021
148300f
Rename InspectorTreeControllerFlutter to InspectorTreeController
matt-ragonese Sep 15, 2021
ac24ae4
Merged InspectorTreeControllerBase and InspectorTreeFixedRowHeightCon…
matt-ragonese Sep 16, 2021
4920dad
Updated FakeInspectorTree with new InspectorTreeController
matt-ragonese Sep 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/devtools_app/lib/src/inspector/inspector_controller.dart
View file
Open in desktop
Expand Up @@ -35,6 +35,7 @@ import 'inspector_screen.dart';
import 'inspector_service.dart';
import 'inspector_text_styles.dart' as inspector_text_styles;
import 'inspector_tree.dart';
import 'inspector_tree_controller.dart';

const inspectorRefQueryParam = 'inspectorRef';

Expand Down
10 changes: 5 additions & 5 deletions packages/devtools_app/lib/src/inspector/inspector_screen.dart
View file
Open in desktop
Expand Up @@ -26,7 +26,7 @@ import '../ui/service_extension_widgets.dart';
import 'inspector_controller.dart';
import 'inspector_screen_details_tab.dart';
import 'inspector_service.dart';
import 'inspector_tree_flutter.dart';
import 'inspector_tree_controller.dart';

class InspectorScreen extends Screen {
const InspectorScreen()
Expand Down Expand Up @@ -66,10 +66,10 @@ class InspectorScreenBodyState extends State<InspectorScreenBody>

InspectorController inspectorController;

InspectorTreeControllerFlutter get summaryTreeController =>
InspectorTreeController get summaryTreeController =>
inspectorController?.inspectorTree;

InspectorTreeControllerFlutter get detailsTreeController =>
InspectorTreeController get detailsTreeController =>
inspectorController?.details?.inspectorTree;

DebuggerController _debuggerController;
Expand All @@ -92,8 +92,8 @@ class InspectorScreenBodyState extends State<InspectorScreenBody>
return;
}
inspectorController = InspectorController(
inspectorTree: InspectorTreeControllerFlutter(),
detailsTree: InspectorTreeControllerFlutter(),
inspectorTree: InspectorTreeController(),
detailsTree: InspectorTreeController(),
treeType: FlutterTreeType.widget,
onExpandCollapseSupported: _onExpandCollapseSupported,
onLayoutExplorerSupported: _onLayoutExplorerSupported,
Expand Down