Fix CodeView's scrollable area
#4448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the `CodeView`'s scrollable area is only as wide as the longest line in the currently selected script, resulting in arguably unexpected behavior when trying to scroll while hovering over the right side of the code area. This change makes each line in the `CodeView` take up the maximum amount of horizontal space possible, making the scrollable area consist of the entire code viewport.
| @@ -376,7 +372,7 @@ class _CodeViewState extends State<CodeView> | |||
| controller: horizontalController, | |||
| child: SizedBox( | |||
| height: constraints.maxHeight, | |||
| width: fileWidth, | |||
| width: constraints.maxWidth, | |||
There was a problem hiding this comment.
I think this should be the max of fileWidth and constraints.maxWidth so that we cover both the case where the file is wider than the view and more narrow than the view
There was a problem hiding this comment.
Ah yes, that makes more sense.
kenzieschmoll
approved these changes
Sep 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
CodeView's scrollable area is only as wide as the longest line in the currently selected script, resulting in arguably unexpected behavior when trying to scroll while hovering over the right side of the code area.This change makes each line in the
CodeViewtake up the maximum amount of horizontal space possible, making the scrollable area consist of the entire code viewport.