Use overflow-anchor as a better fix for scrolling behaviour #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our hack for this caused issues when programatically setting the offset with a smooth scroll. This is the corect fix!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some browsers (Chrome definitely) try to stop the visible portion of the page moving when there are DOM changes above/below. This messed with our virtual table because while we were resizing the padding row at the top, it would scroll down by the same amount. I couldn't find a way to disable it so I put a hack in (keep track of the scrollTop and re-set it afterwards). This worked, but it actually messed with the programatic smooth scrolling because we'd end up re-setting it during the animation and the browser would then leave it as-is (so a long smooth scroll would stop after only a few pixels).
Turns out, there is a proper way to disable it, so this removes our hack and uses that.