Add DevTools section to Flutter sidebar #7598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is not for DevTools extensions. That part will be added once static extension support is available. |
bkonyi
approved these changes
Apr 16, 2024
|
@DanTup merging to unblock the next change I'm preparing. I will address any comments you have in a follow up PR. I did test the change we discussed to make |
3 tasks
DanTup
reviewed
Apr 17, 2024
There was a problem hiding this comment.
LGTM!
I did test the change we discussed to make
debugSessionIdnullable, and it did work as intended.
Great! I've updated the types in Dart-Code/Dart-Code@04dbe4e to make this explicit there (it won't change behaviour, but makes it clearer this is intended).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7165
Fixes #7595
@DanTup
TODO before submitting - fix tests.Edit: tests added in #7604