Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include static DevTools extensions in the Flutter sidebar #7604

Merged
merged 9 commits into from
Apr 25, 2024

Conversation

kenzieschmoll
Copy link
Member

@kenzieschmoll kenzieschmoll commented Apr 17, 2024

Screenshot 2024-04-25 at 9 40 18 AM

Work towards #7569

if (extensions.isEmpty) {
return const Padding(
padding: EdgeInsets.only(left: borderPadding),
child: Text('No extensions detected.'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth just hiding the section if there are none? (it'll probably be empty for most people, at least for a while, so this might just be extra noise)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering if having a section here might help with discoverability. We could event have a help link that opens the DevTools extensions docs. Eventually, it would be nice if the devtools extensions docs could link to a pub.dev link that queries all packages that provide extensions (dart-lang/pub-dev#7216).

@anderdobo @jacob314 do you have an opinion here on what we should show in the sidebar WRT to extensions? Should we hide the DevTools Extensions section when there are none available, or leave the section with an empty message "No extensions detected" for discoverability of the feature?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For a cleaner UI, I think we should hide the DevTools Extensions section when there are none available.

}

void _initExtensions() {
_extensionService = ExtensionService(ignoreServiceConnection: true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(bots are unhappy about this)

The named parameter 'ignoreServiceConnection' isn't defined. Try correcting the name to an existing named parameter's name, or defining a named parameter with the name 'ignoreServiceConnection'. - undefined_named_parameter

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this PR depends on #7612 landing first. 👍

@kenzieschmoll kenzieschmoll marked this pull request as ready for review April 25, 2024 21:20
@kenzieschmoll kenzieschmoll requested a review from a team as a code owner April 25, 2024 21:20
@kenzieschmoll kenzieschmoll requested review from polina-c and removed request for a team April 25, 2024 21:20
@kenzieschmoll kenzieschmoll merged commit e15c472 into flutter:master Apr 25, 2024
23 checks passed
@kenzieschmoll kenzieschmoll deleted the sidebar-static-extensions branch April 25, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants