-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include static DevTools extensions in the Flutter sidebar #7604
Include static DevTools extensions in the Flutter sidebar #7604
Conversation
if (extensions.isEmpty) { | ||
return const Padding( | ||
padding: EdgeInsets.only(left: borderPadding), | ||
child: Text('No extensions detected.'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth just hiding the section if there are none? (it'll probably be empty for most people, at least for a while, so this might just be extra noise)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wondering if having a section here might help with discoverability. We could event have a help link that opens the DevTools extensions docs. Eventually, it would be nice if the devtools extensions docs could link to a pub.dev link that queries all packages that provide extensions (dart-lang/pub-dev#7216).
@anderdobo @jacob314 do you have an opinion here on what we should show in the sidebar WRT to extensions? Should we hide the DevTools Extensions section when there are none available, or leave the section with an empty message "No extensions detected" for discoverability of the feature?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For a cleaner UI, I think we should hide the DevTools Extensions section when there are none available.
} | ||
|
||
void _initExtensions() { | ||
_extensionService = ExtensionService(ignoreServiceConnection: true); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(bots are unhappy about this)
The named parameter 'ignoreServiceConnection' isn't defined. Try correcting the name to an existing named parameter's name, or defining a named parameter with the name 'ignoreServiceConnection'. - undefined_named_parameter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, this PR depends on #7612 landing first. 👍
Work towards #7569