Skip to content

Commit

Permalink
[build] Make --engine-version flag optional (#13803)
Browse files Browse the repository at this point in the history
  • Loading branch information
iskakaushik committed Nov 13, 2019
1 parent 4bc156d commit 98379d7
Showing 1 changed file with 8 additions and 3 deletions.
11 changes: 8 additions & 3 deletions tools/fuchsia/build_fuchsia_artifacts.py
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ def main():

parser.add_argument(
'--engine-version',
required=True,
required=False,
help='Specifies the flutter engine SHA.')

parser.add_argument(
Expand Down Expand Up @@ -272,8 +272,13 @@ def main():
BuildTarget(runtime_mode, arch, product, enable_lto)
BuildBucket(runtime_mode, arch, product)

ProcessCIPDPakcage(args.upload, args.engine_version)
if args.upload:
if args.engine_version is None:
print('--upload requires --engine-version to be specified.')
return 1
ProcessCIPDPakcage(args.upload, args.engine_version)
return 0


if __name__ == '__main__':
main()
sys.exit(main())

0 comments on commit 98379d7

Please sign in to comment.