Expose isolateId for engine #10823

dnfield · 2019-08-10T05:14:18Z

Similar to functionality in what DartExecutor does on the Java side. Earl Grey wants this so it can know which isolate to talk to using service protocol methods.

Should we document that the property written in such a way that it is observable? Also, we really should get these tests running on CI :D

/cc @AlbertWang0116 @matthew-carroll

jmagman · 2019-08-10T05:42:51Z

testing/scenario_app/ios/Scenarios/ScenariosTests/FlutterEngineTest.m

+@end
+
+@implementation FlutterEngineTest
+XCTestExpectation* _isolateIdSetExpectation;


I think keyValueObservingExpectationForObject::: should work here so you don't need to set up your own KVO observation.

jmagman · 2019-08-10T06:25:09Z

shell/platform/darwin/ios/framework/Source/FlutterEngine.mm

@@ -233,6 +236,15 @@ - (void)resetChannels {
 // Channels get a reference to the engine, and therefore need manual
 // cleanup for proper collection.
 - (void)setupChannels {
+  __block FlutterEngine* engine = self;


This is still strongly capturing self even though you set a block local. You can use self directly in the block, it's no different.
Are you trying to prevent a retain cycle? I'm not sure how these handlers are retained, it might not. I don't have the code in front of me at the moment.

Yeah. The messenger is actually dependent on self anyway, so I think it's fine to just capture self.

jmagman · 2019-08-10T06:26:47Z

shell/platform/darwin/ios/framework/Source/FlutterEngine.mm

+                          binaryMessageHandler:^(NSData* message, FlutterBinaryReply reply) {
+                            if (engine) {
+                              engine.isolateId =
+                                  [[[FlutterStringCodec sharedInstance] decode:message] copy];


Set the isolateId property to copy, then you don't need to call copy on set.

Properties with mutable variants (NSArray, NSString, etc) should always be copy so the object isn't mutated out from under it.

jmagman

LGTM!

xster · 2019-08-13T00:52:26Z

Out of scope for this PR but this relates to flutter/flutter#33099

xster · 2019-08-13T00:53:21Z

shell/platform/darwin/ios/framework/Source/FlutterEngine.mm

@@ -233,6 +236,11 @@ - (void)resetChannels {
 // Channels get a reference to the engine, and therefore need manual
 // cleanup for proper collection.
 - (void)setupChannels {
+  [_binaryMessenger setMessageHandlerOnChannel:@"flutter/isolate"


Maybe add a comment on when you would expect to receive this call from the other side.

xster

LGTM

AlbertWang0116 · 2019-08-13T02:54:28Z

testing/scenario_app/ios/Scenarios/ScenariosTests/FlutterEngineTest.m

+
+  XCTAssertTrue([engine runWithEntrypoint:nil]);
+
+  [self waitForExpectationsWithTimeout:30.0 handler:nil];


nit: 30s is too long for a light-weight unit test, and slows down CI progress when there is a true timeout. IMO internally our TAP presubmit should not take more than 1s for loading a Flutter application, so 5s should be enough?

This test runs on a physical device or a simulator. It should never take 30s, but I'd rather it not ever flake due to this - 30s should be enough without ever being not enough.

FWIW, we've had tests run on hardware that's just bogged down because the machine is under heavy load and it takes a while.

OK I see, thanks for explanation.

AlbertWang0116 · 2019-08-13T02:55:35Z

LGTM.

Sorry for the late comments, and really appreciate for adding this support for EarlGrey. Thanks Dan!

git@github.com:flutter/engine.git/compare/ff49ca1c6e5b...7dfdfc6 git log ff49ca1..7dfdfc6 --no-merges --oneline 2019-08-13 skia-flutter-autoroll@skia.org Roll src/third_party/skia b875cc709c7f..f99631100372 (2 commits) (flutter/engine#10974) 2019-08-13 bkonyi@google.com Roll src/third_party/dart 06509e333d..9aea1f3489 (8 commits) 2019-08-13 dnfield@google.com Expose isolateId for engine (flutter/engine#10823) 2019-08-13 bkonyi@google.com Roll src/third_party/dart baebba06af..06509e333d (7 commits) 2019-08-13 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from u8FN9... to z99ul... (flutter/engine#10972) 2019-08-13 skia-flutter-autoroll@skia.org Roll src/third_party/skia ef0406f04761..b875cc709c7f (4 commits) (flutter/engine#10970) 2019-08-13 50503328+flar@users.noreply.github.com include zx::clock from new location to fix Fuchsia autoroll. (flutter/engine#10968) 2019-08-13 mklim@google.com Change SemanticsNode#children lists to be non-null (flutter/engine#10952) 2019-08-13 bkonyi@google.com Roll src/third_party/dart b31df28d72..baebba06af (5 commits) 2019-08-12 bkonyi@google.com Roll src/third_party/dart 896c053803..b31df28d72 (10 commits) 2019-08-12 stuartmorgan@google.com Increase the license block scan from 5k to 6k (flutter/engine#10956) 2019-08-12 iska.kaushik@gmail.com Fix format (flutter/engine#10955) 2019-08-12 skia-flutter-autoroll@skia.org Roll src/third_party/skia 8d1b0bceedd6..ef0406f04761 (8 commits) (flutter/engine#10954) 2019-08-12 bkonyi@google.com Roll src/third_party/dart 32b70ce2a5..896c053803 (1 commits) 2019-08-12 iska.kaushik@gmail.com Fix iOS references to PostPrerollResult (flutter/engine#10949) 2019-08-12 iska.kaushik@gmail.com Allow for dynamic thread merging on IOS for embedded view mutations (flutter/engine#9819) 2019-08-12 mklim@google.com Report JUnit test failures (flutter/engine#10941) 2019-08-12 qxyat2019@gmail.com Fix iOS keyboard crash (flutter/engine#10656) 2019-08-12 jerryzhoujw@gmail.com Bump local podspec's iOS deployment target from 7.0 to 8.0 (flutter/engine#10662) 2019-08-12 skia-flutter-autoroll@skia.org Roll src/third_party/skia c2da70fbef53..8d1b0bceedd6 (2 commits) (flutter/engine#10937) 2019-08-12 bkonyi@google.com Roll src/third_party/dart 9adf3c119e..32b70ce2a5 (3 commits) 2019-08-12 dnfield@google.com iOS JIT support and enhancements for scenarios app (flutter/engine#10820) 2019-08-12 bkonyi@google.com Roll src/third_party/dart 261fd6266b..9adf3c119e (2 commits) 2019-08-12 skia-flutter-autoroll@skia.org Roll src/third_party/skia da037b85352e..c2da70fbef53 (1 commits) (flutter/engine#10924) 2019-08-12 skia-flutter-autoroll@skia.org Roll src/third_party/skia a47c48ef6bce..da037b85352e (3 commits) (flutter/engine#10909) 2019-08-12 bkonyi@google.com Roll src/third_party/dart e29d6d0ecb..261fd6266b (2 commits) 2019-08-12 skia-flutter-autoroll@skia.org Roll src/third_party/skia 9c23a9e790b2..a47c48ef6bce (1 commits) (flutter/engine#10896) 2019-08-11 skia-flutter-autoroll@skia.org Roll src/third_party/skia 5e7271a4598e..9c23a9e790b2 (1 commits) (flutter/engine#10838) 2019-08-11 skia-flutter-autoroll@skia.org Roll src/third_party/skia 3e7fa79f2c79..5e7271a4598e (1 commits) (flutter/engine#10827) 2019-08-10 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from bvUCO... to xqsy5... (flutter/engine#10826) 2019-08-10 skia-flutter-autoroll@skia.org Roll src/third_party/skia 89e43889afd9..3e7fa79f2c79 (1 commits) (flutter/engine#10825) 2019-08-10 skia-flutter-autoroll@skia.org Roll src/third_party/skia fe19203eb7d7..89e43889afd9 (1 commits) (flutter/engine#10824) 2019-08-10 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from HsuAH... to bvUCO... (flutter/engine#10822) 2019-08-10 bkonyi@google.com Roll src/third_party/dart ffefa124a7..e29d6d0ecb (4 commits) 2019-08-10 skia-flutter-autoroll@skia.org Roll src/third_party/skia af89d3972e0b..fe19203eb7d7 (5 commits) (flutter/engine#10819) 2019-08-10 bkonyi@google.com Roll src/third_party/dart 15a3bf82cb..ffefa124a7 (11 commits) 2019-08-09 chris@bracken.jp Roll Dart SDK 78ce916d82..15a3bf82cb (flutter/engine#10810) 2019-08-09 skia-flutter-autoroll@skia.org Roll src/third_party/skia b7b0b3ad538c..af89d3972e0b (7 commits) (flutter/engine#10812) 2019-08-09 jonahwilliams@google.com Revert "Remove flutter_kernel_sdk dart script (#10808)" (flutter/engine#10811) 2019-08-09 iska.kaushik@gmail.com [dart:zircon] Porting Cache re-usable handle wait objects (flutter/engine#10809) 2019-08-09 jonahwilliams@google.com Remove flutter_kernel_sdk dart script (flutter/engine#10808) 2019-08-09 cfontas@google.com change add part to add child (flutter/engine#10787) 2019-08-09 yjbanov@google.com rename stub_ui to web_ui (flutter/engine#10776) 2019-08-09 kpozin@google.com [fuchsia] Migrate from custom FuchsiaFontManager to SkFontMgr_fuchsia (flutter/engine#10700) 2019-08-09 skia-flutter-autoroll@skia.org Roll src/third_party/skia 26cedb4c603b..b7b0b3ad538c (11 commits) (flutter/engine#10807) ...

flutter/engine@be4c8338a Roll src/third_party/dart 20407e28db..45f892df68 (2 commits) flutter/engine@da352d0f7 Revert "Track detailed LibTxt metrics with LineMetrics(flutter/engine#10127)" (flutter/engine#10982) flutter/engine@23700fc1e Roll src/third_party/dart b9217efc77..20407e28db (6 commits) flutter/engine@07f2cfa0e Roll src/third_party/skia 6e1b7bb2b5df..cd8b6d5c1cb8 (10 commits) (flutter/engine#10980) flutter/engine@7711efbf0 Return an empty mapping for an empty file asset (flutter/engine#10815) flutter/engine@663f9a9e1 Roll src/third_party/skia 6ef31815a694..6e1b7bb2b5df (1 commits) (flutter/engine#10979) flutter/engine@0a0a14202 Roll fuchsia/sdk/core/linux-amd64 from z99ul... to j8BvV... (flutter/engine#10978) flutter/engine@e13df85ce Roll src/third_party/dart 9aea1f3489..b9217efc77 (7 commits) flutter/engine@d0698f275 Roll src/third_party/skia f99631100372..6ef31815a694 (3 commits) (flutter/engine#10976) flutter/engine@7dfdfc6fa Roll src/third_party/skia b875cc709c7f..f99631100372 (2 commits) (flutter/engine#10974) flutter/engine@274659564 Roll src/third_party/dart 06509e333d..9aea1f3489 (8 commits) flutter/engine@e22893966 Expose isolateId for engine (flutter/engine#10823) flutter/engine@a18fa3722 Roll src/third_party/dart baebba06af..06509e333d (7 commits) flutter/engine@5909cf930 Roll fuchsia/sdk/core/linux-amd64 from u8FN9... to z99ul... (flutter/engine#10972) flutter/engine@144007da5 Roll src/third_party/skia ef0406f04761..b875cc709c7f (4 commits) (flutter/engine#10970) flutter/engine@6a4dfa7aa include zx::clock from new location to fix Fuchsia autoroll. (flutter/engine#10968) flutter/engine@ed88d0a44 Change SemanticsNode#children lists to be non-null (flutter/engine#10952) flutter/engine@853464e36 Roll src/third_party/dart b31df28d72..baebba06af (5 commits) flutter/engine@fb317b085 Roll src/third_party/dart 896c053803..b31df28d72 (10 commits) flutter/engine@20b7ea234 Increase the license block scan from 5k to 6k (flutter/engine#10956) flutter/engine@a438469aa Fix format (flutter/engine#10955) flutter/engine@70dd606ba Roll src/third_party/skia 8d1b0bceedd6..ef0406f04761 (8 commits) (flutter/engine#10954) flutter/engine@cff3f3d66 Roll src/third_party/dart 32b70ce2a5..896c053803 (1 commits) flutter/engine@b5c198b69 Fix iOS references to PostPrerollResult (flutter/engine#10949) flutter/engine@971a63915 Allow for dynamic thread merging on IOS for embedded view mutations (flutter/engine#9819) flutter/engine@c92a0d992 Report JUnit test failures (flutter/engine#10941) flutter/engine@e95125aad Fix iOS keyboard crash (flutter/engine#10656) flutter/engine@a50ec07d5 Bump local podspec's iOS deployment target from 7.0 to 8.0 (flutter/engine#10662) flutter/engine@0ce28b100 Roll src/third_party/skia c2da70fbef53..8d1b0bceedd6 (2 commits) (flutter/engine#10937) flutter/engine@07ee128c2 Roll src/third_party/dart 9adf3c119e..32b70ce2a5 (3 commits) flutter/engine@79c50123a iOS JIT support and enhancements for scenarios app (flutter/engine#10820) flutter/engine@d3be62888 Roll src/third_party/dart 261fd6266b..9adf3c119e (2 commits) flutter/engine@68b749624 Roll src/third_party/skia da037b85352e..c2da70fbef53 (1 commits) (flutter/engine#10924) flutter/engine@d3523b9b7 Roll src/third_party/skia a47c48ef6bce..da037b85352e (3 commits) (flutter/engine#10909) flutter/engine@b39019d57 Roll src/third_party/dart e29d6d0ecb..261fd6266b (2 commits) flutter/engine@19f564acf Roll src/third_party/skia 9c23a9e790b2..a47c48ef6bce (1 commits) (flutter/engine#10896) flutter/engine@4099cb146 Roll src/third_party/skia 5e7271a4598e..9c23a9e790b2 (1 commits) (flutter/engine#10838) flutter/engine@a3fa41b3b Roll src/third_party/skia 3e7fa79f2c79..5e7271a4598e (1 commits) (flutter/engine#10827) flutter/engine@99355b086 Roll fuchsia/sdk/core/linux-amd64 from bvUCO... to xqsy5... (flutter/engine#10826) flutter/engine@8a068a1bd Roll src/third_party/skia 89e43889afd9..3e7fa79f2c79 (1 commits) (flutter/engine#10825) flutter/engine@ee6267d04 Roll src/third_party/skia fe19203eb7d7..89e43889afd9 (1 commits) (flutter/engine#10824) flutter/engine@7ad538dcc Roll fuchsia/sdk/core/linux-amd64 from HsuAH... to bvUCO... (flutter/engine#10822) flutter/engine@cbc2fe6e1 Roll src/third_party/dart ffefa124a7..e29d6d0ecb (4 commits) flutter/engine@0afba6b1f Roll src/third_party/skia af89d3972e0b..fe19203eb7d7 (5 commits) (flutter/engine#10819) flutter/engine@6c678bfca Roll src/third_party/dart 15a3bf82cb..ffefa124a7 (11 commits) flutter/engine@03caa67ac Roll Dart SDK 78ce916d82..15a3bf82cb (flutter/engine#10810) flutter/engine@e096f7830 Roll src/third_party/skia b7b0b3ad538c..af89d3972e0b (7 commits) (flutter/engine#10812) flutter/engine@cb1628986 Revert "Remove flutter_kernel_sdk dart script (flutter/engine#10808)" (flutter/engine#10811) flutter/engine@42afb1abb [dart:zircon] Porting Cache re-usable handle wait objects (flutter/engine#10809) flutter/engine@1b287524e Remove flutter_kernel_sdk dart script (flutter/engine#10808) flutter/engine@58f4f27a4 change add part to add child (flutter/engine#10787) flutter/engine@708fc625d rename stub_ui to web_ui (flutter/engine#10776) flutter/engine@70de3ec2c [fuchsia] Migrate from custom FuchsiaFontManager to SkFontMgr_fuchsia (flutter/engine#10700) flutter/engine@e0beaff61 Roll src/third_party/skia 26cedb4c603b..b7b0b3ad538c (11 commits) (flutter/engine#10807) flutter/engine@83b640d4b Rename flutter_java.jar and flutter_engine.jar so they match the Maven comvention (flutter/engine#10797) flutter/engine@c5d3c90d9 Roll fuchsia/sdk/core/linux-amd64 from 9xVXx... to HsuAH... (flutter/engine#10806) flutter/engine@97326b242 Roll src/third_party/dart 3d9a356f6e..78ce916d82 (7 commits) flutter/engine@086c0d50e Roll src/third_party/skia b2151310068b..26cedb4c603b (1 commits) (flutter/engine#10804) flutter/engine@1c75ee7c0 Roll src/third_party/skia 059bf776c184..b2151310068b (3 commits) (flutter/engine#10803) flutter/engine@2611a6eef Roll src/third_party/dart f29f41f1a5..3d9a356f6e (65 commits) flutter/engine@09a05f8b9 Roll src/third_party/skia 4d557e3df433..059bf776c184 (1 commits) (flutter/engine#10801)

Expose isolateId for engine

0eeaba2

dnfield requested review from xster and jmagman August 10, 2019 05:14

googlebot added the cla: yes label Aug 10, 2019

jmagman reviewed Aug 10, 2019

View reviewed changes

dnfield added 2 commits August 9, 2019 22:58

use better observation method

f70143d

format

21365a8

jmagman requested changes Aug 10, 2019

View reviewed changes

copy

140c987

jmagman approved these changes Aug 10, 2019

View reviewed changes

xster reviewed Aug 13, 2019

View reviewed changes

AlbertWang0116 reviewed Aug 13, 2019

View reviewed changes

dnfield added 2 commits August 12, 2019 20:04

Update FlutterEngine.mm

9439077

Update FlutterEngine.mm

b875cd0

dnfield merged commit e228939 into flutter:master Aug 13, 2019

dnfield deleted the isolate_id_ios branch August 13, 2019 04:21

engine-flutter-autoroll mentioned this pull request Aug 13, 2019

Roll engine ff49ca1c6e5b..e22893966a24 (50 commits) flutter/flutter#38393

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 13, 2019

e228939 Expose isolateId for engine (flutter/engine#10823)

f5a71de

engine-flutter-autoroll mentioned this pull request Aug 13, 2019

Roll engine ff49ca1c6e5b..e22893966a24 (50 commits) flutter/flutter#38394

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 13, 2019

e228939 Expose isolateId for engine (flutter/engine#10823)

b1e543e

engine-flutter-autoroll mentioned this pull request Aug 13, 2019

Roll engine ff49ca1c6e5b..e22893966a24 (50 commits) flutter/flutter#38395

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 13, 2019

e228939 Expose isolateId for engine (flutter/engine#10823)

c36dd31

engine-flutter-autoroll mentioned this pull request Aug 13, 2019

Roll engine ff49ca1c6e5b..7dfdfc6faeb6 (52 commits) flutter/flutter#38397

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 13, 2019

e228939 Expose isolateId for engine (flutter/engine#10823)

348b56e

engine-flutter-autoroll mentioned this pull request Aug 13, 2019

Roll engine ff49ca1c6e5b..7dfdfc6faeb6 (52 commits) flutter/flutter#38398

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 13, 2019

e228939 Expose isolateId for engine (flutter/engine#10823)

4c2eb5b

engine-flutter-autoroll mentioned this pull request Aug 13, 2019

Roll engine ff49ca1c6e5b..7dfdfc6faeb6 (52 commits) flutter/flutter#38400

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 13, 2019

e228939 Expose isolateId for engine (flutter/engine#10823)

eee39d4

engine-flutter-autoroll mentioned this pull request Aug 13, 2019

Roll engine ff49ca1c6e5b..7dfdfc6faeb6 (52 commits) flutter/flutter#38402

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 13, 2019

e228939 Expose isolateId for engine (flutter/engine#10823)

d3b42bf

engine-flutter-autoroll mentioned this pull request Aug 13, 2019

Roll engine ff49ca1c6e5b..7dfdfc6faeb6 (52 commits) flutter/flutter#38403

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 13, 2019

e228939 Expose isolateId for engine (flutter/engine#10823)

d0a7222

engine-flutter-autoroll mentioned this pull request Aug 13, 2019

Roll engine ff49ca1c6e5b..7dfdfc6faeb6 (52 commits) flutter/flutter#38404

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 13, 2019

e228939 Expose isolateId for engine (flutter/engine#10823)

cc05883

engine-flutter-autoroll mentioned this pull request Aug 13, 2019

Roll engine ff49ca1c6e5b..7dfdfc6faeb6 (52 commits) flutter/flutter#38405

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 13, 2019

e228939 Expose isolateId for engine (flutter/engine#10823)

517834d

engine-flutter-autoroll mentioned this pull request Aug 13, 2019

Roll engine ff49ca1c6e5b..7dfdfc6faeb6 (52 commits) flutter/flutter#38408

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 13, 2019

e228939 Expose isolateId for engine (flutter/engine#10823)

68e667a

engine-flutter-autoroll mentioned this pull request Aug 13, 2019

Roll engine ff49ca1c6e5b..7dfdfc6faeb6 (52 commits) flutter/flutter#38409

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 13, 2019

e228939 Expose isolateId for engine (flutter/engine#10823)

2f3ed9d

engine-flutter-autoroll mentioned this pull request Aug 13, 2019

Roll engine ff49ca1c6e5b..7dfdfc6faeb6 (52 commits) flutter/flutter#38411

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 13, 2019

e228939 Expose isolateId for engine (flutter/engine#10823)

56dc02e

engine-flutter-autoroll mentioned this pull request Aug 13, 2019

Roll engine ff49ca1c6e5b..7dfdfc6faeb6 (52 commits) flutter/flutter#38413

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 13, 2019

e228939 Expose isolateId for engine (flutter/engine#10823)

d2c71ed

engine-flutter-autoroll mentioned this pull request Aug 13, 2019

Roll engine ff49ca1c6e5b..23700fc1ee58 (59 commits) flutter/flutter#38482

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 13, 2019

e228939 Expose isolateId for engine (flutter/engine#10823)

8d65f11

engine-flutter-autoroll mentioned this pull request Aug 13, 2019

Roll engine ff49ca1c6e5b..23700fc1ee58 (59 commits) flutter/flutter#38484

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 13, 2019

e228939 Expose isolateId for engine (flutter/engine#10823)

e2188a7

engine-flutter-autoroll mentioned this pull request Aug 13, 2019

Roll engine ff49ca1c6e5b..da352d0f729d (60 commits) flutter/flutter#38489

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 13, 2019

e228939 Expose isolateId for engine (flutter/engine#10823)

7f7ab82

engine-flutter-autoroll mentioned this pull request Aug 13, 2019

Roll engine ff49ca1c6e5b..da352d0f729d (60 commits) flutter/flutter#38493

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Aug 13, 2019

e228939 Expose isolateId for engine (flutter/engine#10823)

3fba522

stuartmorgan mentioned this pull request Aug 13, 2019

Roll engine ff49ca1c6e5b..be4c8338a6ab (61 commits) flutter/flutter#38495

Merged

9 tasks

jason-simmons mentioned this pull request Sep 22, 2021

[Flutter Engine] DartExecutor#setIsolateServiceIdListener is public, but its parameter type (IsolateServiceIdListener) is package-private. flutter/flutter#90182

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Expose isolateId for engine #10823

Expose isolateId for engine #10823

dnfield commented Aug 10, 2019

jmagman Aug 10, 2019

jmagman Aug 10, 2019

dnfield Aug 10, 2019

jmagman Aug 10, 2019

dnfield Aug 10, 2019

jmagman left a comment

xster commented Aug 13, 2019

xster Aug 13, 2019

xster left a comment

AlbertWang0116 Aug 13, 2019

dnfield Aug 13, 2019

dnfield Aug 13, 2019

AlbertWang0116 Aug 13, 2019

AlbertWang0116 commented Aug 13, 2019


		XCTAssertTrue([engine runWithEntrypoint:nil]);

		[self waitForExpectationsWithTimeout:30.0 handler:nil];

Expose isolateId for engine #10823

Expose isolateId for engine #10823

Conversation

dnfield commented Aug 10, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jmagman left a comment

Choose a reason for hiding this comment

xster commented Aug 13, 2019

Choose a reason for hiding this comment

xster left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AlbertWang0116 commented Aug 13, 2019