Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

Commit b5c198b

Browse files
authored
Fix iOS references to PostPrerollResult (#10949)
1 parent 971a639 commit b5c198b

File tree

4 files changed

+6
-6
lines changed

4 files changed

+6
-6
lines changed

shell/platform/darwin/ios/framework/Source/FlutterPlatformViews.mm

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@
173173

174174
const int FlutterPlatformViewsController::kDefaultMergedLeaseDuration;
175175

176-
bool FlutterPlatformViewsController::PostPrerollAction(
176+
PostPrerollResult FlutterPlatformViewsController::PostPrerollAction(
177177
fml::RefPtr<fml::GpuThreadMerger> gpu_thread_merger) {
178178
const bool uiviews_mutated = HasPendingViewOperations();
179179
if (uiviews_mutated) {
@@ -182,10 +182,10 @@
182182
} else {
183183
CancelFrame();
184184
gpu_thread_merger->MergeWithLease(kDefaultMergedLeaseDuration);
185-
return true;
185+
return PostPrerollResult::kSuccess;
186186
}
187187
}
188-
return false;
188+
return PostPrerollResult::kResubmitFrame;
189189
}
190190

191191
void FlutterPlatformViewsController::PrerollCompositeEmbeddedView(

shell/platform/darwin/ios/framework/Source/FlutterPlatformViews_Internal.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,7 @@ class FlutterPlatformViewsController {
9191
// returns nil.
9292
NSObject<FlutterPlatformView>* GetPlatformViewByID(int view_id);
9393

94-
bool PostPrerollAction(fml::RefPtr<fml::GpuThreadMerger> gpu_thread_merger);
94+
PostPrerollResult PostPrerollAction(fml::RefPtr<fml::GpuThreadMerger> gpu_thread_merger);
9595

9696
std::vector<SkCanvas*> GetCurrentCanvases();
9797

shell/platform/darwin/ios/ios_surface_gl.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ class IOSSurfaceGL final : public IOSSurface,
6262
std::unique_ptr<flutter::EmbeddedViewParams> params) override;
6363

6464
// |flutter::ExternalViewEmbedder|
65-
bool PostPrerollAction(fml::RefPtr<fml::GpuThreadMerger> gpu_thread_merger) override;
65+
PostPrerollResult PostPrerollAction(fml::RefPtr<fml::GpuThreadMerger> gpu_thread_merger) override;
6666

6767
// |flutter::ExternalViewEmbedder|
6868
std::vector<SkCanvas*> GetCurrentCanvases() override;

shell/platform/darwin/ios/ios_surface_gl.mm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@
106106
platform_views_controller->PrerollCompositeEmbeddedView(view_id, std::move(params));
107107
}
108108

109-
bool IOSSurfaceGL::PostPrerollAction(fml::RefPtr<fml::GpuThreadMerger> gpu_thread_merger) {
109+
PostPrerollResult IOSSurfaceGL::PostPrerollAction(fml::RefPtr<fml::GpuThreadMerger> gpu_thread_merger) {
110110
FlutterPlatformViewsController* platform_views_controller = GetPlatformViewsController();
111111
FML_CHECK(platform_views_controller != nullptr);
112112
return platform_views_controller->PostPrerollAction(gpu_thread_merger);

0 commit comments

Comments
 (0)