Add Chrome to Dockerfile #11210
Merged
Add Chrome to Dockerfile #11210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this up and running as latest? |
|
Not yet. Building and testing locally right now. |
yjbanov
added
Work in progress (WIP)
|
I pushed the image to docker. |
|
Is this PR good to submit? |
yjbanov
force-pushed
the
chrome-in-docker
branch
from
8b9fde1
to
f843721
Compare
yjbanov
force-pushed
the
chrome-in-docker
branch
from
f843721
to
2f8cffd
Compare
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 20, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Aug 20, 2019
git@github.com:flutter/engine.git/compare/ca86f6d7e153...0e90cb4 git log ca86f6d..0e90cb4 --no-merges --oneline 2019-08-20 jason-simmons@users.noreply.github.com Fix a segfault in EmbedderTest.CanSpecifyCustomTaskRunner (flutter/engine#11305) 2019-08-20 yjbanov@google.com Add Chrome to Dockerfile (flutter/engine#11210) The AutoRoll server is located here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff (liyuqian@google.com), and stop the roller if necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Chrome to Dockerfile so we can run Web tests on Cirrus.