-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix parameter naming in docs #12732
Merged
Merged
Fix parameter naming in docs #12732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaaclarke
approved these changes
Oct 2, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 2, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Oct 2, 2019
git@github.com:flutter/engine.git/compare/4651df4d35af...aa8fcbb git log 4651df4..aa8fcbb --no-merges --oneline 2019-10-02 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from 7v4fg... to AGoPT... (flutter/engine#12745) 2019-10-02 gspencergoog@users.noreply.github.com Stop setting the accessibility text if a node has SCOPES_ROUTE set. (flutter/engine#12730) 2019-10-02 bkonyi@google.com Roll src/third_party/dart 431176ea26..98b286de21 (16 commits) 2019-10-02 skia-flutter-autoroll@skia.org Roll src/third_party/skia cf0a9a628490..a1ea0a96f490 (1 commits) (flutter/engine#12743) 2019-10-02 jiahaog@users.noreply.github.com Fix parameter naming in docs (flutter/engine#12732) 2019-10-02 iska.kaushik@gmail.com Update linux toolchain for fuchsia (flutter/engine#12742) 2019-10-02 skia-flutter-autoroll@skia.org Roll src/third_party/skia 1c934fade666..cf0a9a628490 (3 commits) (flutter/engine#12741) 2019-10-02 skia-flutter-autoroll@skia.org Roll src/third_party/skia 015c2feb1288..1c934fade666 (3 commits) (flutter/engine#12740) 2019-10-02 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from L_AEL... to LSKbP... (flutter/engine#12739) 2019-10-02 skia-flutter-autoroll@skia.org Roll src/third_party/skia 674f77a24b62..015c2feb1288 (1 commits) (flutter/engine#12738) 2019-10-02 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from Q4sFH... to 7v4fg... (flutter/engine#12737) 2019-10-02 bkonyi@google.com Roll src/third_party/dart cbf6a233fc..431176ea26 (1 commits) 2019-10-02 iska.kaushik@gmail.com [flutter_runner] Make rd and rx uniform (flutter/engine#12733) 2019-10-02 skia-flutter-autoroll@skia.org Roll src/third_party/skia 9e514a183b99..674f77a24b62 (1 commits) (flutter/engine#12734) 2019-10-01 bkonyi@google.com Roll src/third_party/dart 1103600280..cbf6a233fc (8 commits) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC liyuqian@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Nov 26, 2019
git@github.com:flutter/engine.git/compare/4651df4d35af...aa8fcbb git log 4651df4..aa8fcbb --no-merges --oneline 2019-10-02 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from 7v4fg... to AGoPT... (flutter/engine#12745) 2019-10-02 gspencergoog@users.noreply.github.com Stop setting the accessibility text if a node has SCOPES_ROUTE set. (flutter/engine#12730) 2019-10-02 bkonyi@google.com Roll src/third_party/dart 431176ea26..98b286de21 (16 commits) 2019-10-02 skia-flutter-autoroll@skia.org Roll src/third_party/skia cf0a9a628490..a1ea0a96f490 (1 commits) (flutter/engine#12743) 2019-10-02 jiahaog@users.noreply.github.com Fix parameter naming in docs (flutter/engine#12732) 2019-10-02 iska.kaushik@gmail.com Update linux toolchain for fuchsia (flutter/engine#12742) 2019-10-02 skia-flutter-autoroll@skia.org Roll src/third_party/skia 1c934fade666..cf0a9a628490 (3 commits) (flutter/engine#12741) 2019-10-02 skia-flutter-autoroll@skia.org Roll src/third_party/skia 015c2feb1288..1c934fade666 (3 commits) (flutter/engine#12740) 2019-10-02 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from L_AEL... to LSKbP... (flutter/engine#12739) 2019-10-02 skia-flutter-autoroll@skia.org Roll src/third_party/skia 674f77a24b62..015c2feb1288 (1 commits) (flutter/engine#12738) 2019-10-02 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from Q4sFH... to 7v4fg... (flutter/engine#12737) 2019-10-02 bkonyi@google.com Roll src/third_party/dart cbf6a233fc..431176ea26 (1 commits) 2019-10-02 iska.kaushik@gmail.com [flutter_runner] Make rd and rx uniform (flutter/engine#12733) 2019-10-02 skia-flutter-autoroll@skia.org Roll src/third_party/skia 9e514a183b99..674f77a24b62 (1 commits) (flutter/engine#12734) 2019-10-01 bkonyi@google.com Roll src/third_party/dart 1103600280..cbf6a233fc (8 commits) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC liyuqian@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compilation breaks internally after #12708. E.g: