Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parameter naming in docs #12732

Merged
merged 1 commit into from
Oct 2, 2019
Merged

Fix parameter naming in docs #12732

merged 1 commit into from
Oct 2, 2019

Conversation

jiahaog
Copy link
Member

@jiahaog jiahaog commented Oct 2, 2019 •
edited

Compilation breaks internally after #12708. E.g:

error: parameter 'nibNameOrNil' not found in the function declaration [-Werror,-Wdocumentation]
 * @param nibNameOrNil The NIB name to initialize this UIViewController with.

@jiahaog jiahaog requested a review from gaaclarke October 2, 2019 00:27
gaaclarke
gaaclarke approved these changes Oct 2, 2019
View reviewed changes
Copy link
Member

@gaaclarke gaaclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jiahaog jiahaog merged commit 7bb1a6b into master Oct 2, 2019
@jiahaog jiahaog deleted the jiahaog-patch-1 branch October 2, 2019 15:59
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 2, 2019
@engine-flutter-autoroll
7bb1a6b Fix parameter naming in docs (flutter/engine#12732)
8d5198c
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 2, 2019
Merged
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Oct 2, 2019
@engine-flutter-autoroll
Roll engine 4651df4..aa8fcbb (15 commits) (#41809)
4158404 
git@github.com:flutter/engine.git/compare/4651df4d35af...aa8fcbb

git log 4651df4..aa8fcbb --no-merges --oneline
2019-10-02 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from 7v4fg... to AGoPT... (flutter/engine#12745)
2019-10-02 gspencergoog@users.noreply.github.com Stop setting the accessibility text if a node has SCOPES_ROUTE set. (flutter/engine#12730)
2019-10-02 bkonyi@google.com Roll src/third_party/dart 431176ea26..98b286de21 (16 commits)
2019-10-02 skia-flutter-autoroll@skia.org Roll src/third_party/skia cf0a9a628490..a1ea0a96f490 (1 commits) (flutter/engine#12743)
2019-10-02 jiahaog@users.noreply.github.com Fix parameter naming in docs (flutter/engine#12732)
2019-10-02 iska.kaushik@gmail.com Update linux toolchain for fuchsia (flutter/engine#12742)
2019-10-02 skia-flutter-autoroll@skia.org Roll src/third_party/skia 1c934fade666..cf0a9a628490 (3 commits) (flutter/engine#12741)
2019-10-02 skia-flutter-autoroll@skia.org Roll src/third_party/skia 015c2feb1288..1c934fade666 (3 commits) (flutter/engine#12740)
2019-10-02 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from L_AEL... to LSKbP... (flutter/engine#12739)
2019-10-02 skia-flutter-autoroll@skia.org Roll src/third_party/skia 674f77a24b62..015c2feb1288 (1 commits) (flutter/engine#12738)
2019-10-02 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from Q4sFH... to 7v4fg... (flutter/engine#12737)
2019-10-02 bkonyi@google.com Roll src/third_party/dart cbf6a233fc..431176ea26 (1 commits)
2019-10-02 iska.kaushik@gmail.com [flutter_runner] Make rd and rx uniform (flutter/engine#12733)
2019-10-02 skia-flutter-autoroll@skia.org Roll src/third_party/skia 9e514a183b99..674f77a24b62 (1 commits) (flutter/engine#12734)
2019-10-01 bkonyi@google.com Roll src/third_party/dart 1103600280..cbf6a233fc (8 commits)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC liyuqian@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Nov 26, 2019
@engine-flutter-autoroll @Inconnu08
Roll engine 4651df4..aa8fcbb (15 commits) (flutter#41809)
59d93a3 
git@github.com:flutter/engine.git/compare/4651df4d35af...aa8fcbb

git log 4651df4..aa8fcbb --no-merges --oneline
2019-10-02 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from 7v4fg... to AGoPT... (flutter/engine#12745)
2019-10-02 gspencergoog@users.noreply.github.com Stop setting the accessibility text if a node has SCOPES_ROUTE set. (flutter/engine#12730)
2019-10-02 bkonyi@google.com Roll src/third_party/dart 431176ea26..98b286de21 (16 commits)
2019-10-02 skia-flutter-autoroll@skia.org Roll src/third_party/skia cf0a9a628490..a1ea0a96f490 (1 commits) (flutter/engine#12743)
2019-10-02 jiahaog@users.noreply.github.com Fix parameter naming in docs (flutter/engine#12732)
2019-10-02 iska.kaushik@gmail.com Update linux toolchain for fuchsia (flutter/engine#12742)
2019-10-02 skia-flutter-autoroll@skia.org Roll src/third_party/skia 1c934fade666..cf0a9a628490 (3 commits) (flutter/engine#12741)
2019-10-02 skia-flutter-autoroll@skia.org Roll src/third_party/skia 015c2feb1288..1c934fade666 (3 commits) (flutter/engine#12740)
2019-10-02 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from L_AEL... to LSKbP... (flutter/engine#12739)
2019-10-02 skia-flutter-autoroll@skia.org Roll src/third_party/skia 674f77a24b62..015c2feb1288 (1 commits) (flutter/engine#12738)
2019-10-02 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from Q4sFH... to 7v4fg... (flutter/engine#12737)
2019-10-02 bkonyi@google.com Roll src/third_party/dart cbf6a233fc..431176ea26 (1 commits)
2019-10-02 iska.kaushik@gmail.com [flutter_runner] Make rd and rx uniform (flutter/engine#12733)
2019-10-02 skia-flutter-autoroll@skia.org Roll src/third_party/skia 9e514a183b99..674f77a24b62 (1 commits) (flutter/engine#12734)
2019-10-01 bkonyi@google.com Roll src/third_party/dart 1103600280..cbf6a233fc (8 commits)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC liyuqian@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaaclarke gaaclarke gaaclarke approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
3 participants
@jiahaog @gaaclarke @googlebot