Open source canvas tests from flutter_web_ui #12819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤦♂ |
yjbanov
approved these changes
Oct 7, 2019
Reimplement some painter tests as screenshot tests on canvas. Needs flutter/goldens#53 Fixes flutter/flutter#42027
* Add latest hash to dev/goldens_lock.yaml * Rename (with git mv) *scuba_test.dart -> *golden_test.dart
|
Force-pushed after rebasing the branch |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 8, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Oct 8, 2019
git@github.com:flutter/engine.git/compare/49dbaae818cd...3a445ed git log 49dbaae..3a445ed --no-merges --oneline 2019-10-08 30870216+gaaclarke@users.noreply.github.com Made _printDebug only happen on debug builds of the engine for now. (flutter/engine#12980) 2019-10-08 devoncarew@google.com remove references to package:_chrome (flutter/engine#12931) 2019-10-08 ditman@gmail.com Open source canvas tests from flutter_web_ui (flutter/engine#12819) 2019-10-08 mouad.debbar@gmail.com Prevent default when Tab is clicked (flutter/engine#12986) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Nov 26, 2019
git@github.com:flutter/engine.git/compare/49dbaae818cd...3a445ed git log 49dbaae..3a445ed --no-merges --oneline 2019-10-08 30870216+gaaclarke@users.noreply.github.com Made _printDebug only happen on debug builds of the engine for now. (flutter/engine#12980) 2019-10-08 devoncarew@google.com remove references to package:_chrome (flutter/engine#12931) 2019-10-08 ditman@gmail.com Open source canvas tests from flutter_web_ui (flutter/engine#12819) 2019-10-08 mouad.debbar@gmail.com Prevent default when Tab is clicked (flutter/engine#12986) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC chinmaygarde@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reimplement some painter tests as canvas screenshot tests in the engine.
Needs flutter/goldens#53
Fixes flutter/flutter#42027
(Set to WIP because I need to get the goldens pushed, then update the hash here)