[web] Add goldens for flutter_web_ui backported tests.#53
Merged
ditman merged 1 commit intoflutter:masterfrom Oct 7, 2019
ditman:canvas-backport
Merged
[web] Add goldens for flutter_web_ui backported tests.#53ditman merged 1 commit intoflutter:masterfrom ditman:canvas-backport
ditman merged 1 commit intoflutter:masterfrom
ditman:canvas-backport
Conversation
yjbanov
approved these changes
Oct 7, 2019
ditman
added a commit
to flutter/engine
that referenced
this pull request
Oct 8, 2019
* Open source canvas tests from flutter_web_ui Reimplement some painter tests as screenshot tests on canvas. Needs flutter/goldens#53 Fixes flutter/flutter#42027 * Remove whitespace * Address PR feedback * Add latest hash to dev/goldens_lock.yaml * Rename (with git mv) *scuba_test.dart -> *golden_test.dart
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are not copy-pasted directly from our internal repo, because they were rendering at a higher DPI, and they need to be 1:1.
Needed for flutter/flutter#42027