Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid accessing the Cocoa view on the GPU or IO task runners. #13295

Merged
merged 1 commit into from
Oct 22, 2019
Merged

Avoid accessing the Cocoa view on the GPU or IO task runners. #13295

merged 1 commit into from
Oct 22, 2019

Conversation

chinmaygarde
Copy link
Member

The view was being accessed from a background thread so its OpenGL context could be accessed. This tripped thread safety assertions in Cocoa. Now the OpenGL context is stashed in the FlutterEngine instance itself.

@chinmaygarde
Avoid accessing the Cocoa view on the GPU or IO task runners.
d838a87 
The view was being accessed from a background thread so its OpenGL context could be accessed. This tripped thread safety assertions in Cocoa. Now the OpenGL context is stashed in the FlutterEngine instance itself.
gaaclarke
gaaclarke approved these changes Oct 22, 2019
View reviewed changes
Copy link
Member

@gaaclarke gaaclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add thread asserts in some of these methods?

@chinmaygarde
Copy link
Member Author

Cocoa already does this for us. That's how I found the same.

@chinmaygarde chinmaygarde merged commit 97f5ad4 into flutter:master Oct 22, 2019
@chinmaygarde chinmaygarde deleted the no_resize_crash branch October 22, 2019 21:21
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 22, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 22, 2019
@engine-flutter-autoroll
97f5ad4 Avoid accessing the Cocoa view on the GPU or IO task runners. (…
e68e7e4 
…flutter/engine#13295)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 22, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 22, 2019
@engine-flutter-autoroll
97f5ad4 Avoid accessing the Cocoa view on the GPU or IO task runners. (…
10aa26f 
…flutter/engine#13295)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 23, 2019
@engine-flutter-autoroll
97f5ad4 Avoid accessing the Cocoa view on the GPU or IO task runners. (…
e1b6d4a 
…flutter/engine#13295)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 23, 2019
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 23, 2019
@engine-flutter-autoroll
97f5ad4 Avoid accessing the Cocoa view on the GPU or IO task runners. (…
9f123b7 
…flutter/engine#13295)
This was referenced Oct 23, 2019
Closed
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 23, 2019
@engine-flutter-autoroll
97f5ad4 Avoid accessing the Cocoa view on the GPU or IO task runners. (…
45b812d 
…flutter/engine#13295)
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 23, 2019
@engine-flutter-autoroll
97f5ad4 Avoid accessing the Cocoa view on the GPU or IO task runners. (…
ef7ff35 
…flutter/engine#13295)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 23, 2019
Merged
engine-flutter-autoroll added a commit to flutter/flutter that referenced this pull request Oct 23, 2019
@engine-flutter-autoroll
Roll engine a064063..b5a33d4 (17 commits) (#43308)
58c46a8 
git@github.com:flutter/engine.git/compare/a064063e3f63...b5a33d4

git log a064063..b5a33d4 --no-merges --oneline
2019-10-23 chinmaygarde@google.com Allow embedders to update preferrred locales. (flutter/engine#13238)
2019-10-23 jason-simmons@users.noreply.github.com Show strace logs when the Fuchsia gen_package script gets an error from the packaging tool (flutter/engine#13298)
2019-10-22 ferhat@gmail.com [web] Cupertino dynamic color fix. (flutter/engine#13296)
2019-10-22 bkonyi@google.com Roll src/third_party/dart 6a65ea9cad..4ab09db0f4 (2 commits)
2019-10-22 garyq@google.com Update harfbuzz to 2.6.2, Roll buildroot to a518e (flutter/engine#13242)
2019-10-22 ferhat@gmail.com Fix decode feature detection in HtmlCodec (flutter/engine#13274)
2019-10-22 chinmaygarde@google.com Avoid accessing the Cocoa view on the GPU or IO task runners. (flutter/engine#13295)
2019-10-22 gw280@google.com Make flutter_tester support multithreaded testing, and run all Dart tests in both single and multithreaded configurations (flutter/engine#13273)
2019-10-22 30870216+gaaclarke@users.noreply.github.com Made restarting the Engine remember the last entrypoint that was used. (flutter/engine#13289)
2019-10-22 skia-flutter-autoroll@skia.org Roll src/third_party/skia f3f8ac37e468..2638f3d44b02 (12 commits) (flutter/engine#13291)
2019-10-22 hterkelsen@users.noreply.github.com Flesh out the CanvasKit backend some more (flutter/engine#13275)
2019-10-22 rmacnak@google.com Roll Dart to 6a65ea9cad4b014f88d2f1be1b321db493725a1c. (flutter/engine#13294)
2019-10-22 chinmaygarde@google.com Disable flaky test ShellTest_ReportTimingsIsCalled. (flutter/engine#13292)
2019-10-22 jason-simmons@users.noreply.github.com Do not request executable permission on Fuchsia file mappings unless it is required (flutter/engine#13290)
2019-10-22 bkonyi@google.com Roll src/third_party/dart e1c409792c..5814319bf9 (9 commits)
2019-10-22 30870216+gaaclarke@users.noreply.github.com Revert "Made restarting the Engine remember the last entrypoint that was used. (#13264)" (flutter/engine#13287)
2019-10-22 30870216+gaaclarke@users.noreply.github.com Made restarting the Engine remember the last entrypoint that was used. (flutter/engine#13264)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Inconnu08 pushed a commit to Inconnu08/flutter that referenced this pull request Nov 26, 2019
@engine-flutter-autoroll @Inconnu08
Roll engine a064063..b5a33d4 (17 commits) (flutter#43308)
55b2459 
git@github.com:flutter/engine.git/compare/a064063e3f63...b5a33d4

git log a064063..b5a33d4 --no-merges --oneline
2019-10-23 chinmaygarde@google.com Allow embedders to update preferrred locales. (flutter/engine#13238)
2019-10-23 jason-simmons@users.noreply.github.com Show strace logs when the Fuchsia gen_package script gets an error from the packaging tool (flutter/engine#13298)
2019-10-22 ferhat@gmail.com [web] Cupertino dynamic color fix. (flutter/engine#13296)
2019-10-22 bkonyi@google.com Roll src/third_party/dart 6a65ea9cad..4ab09db0f4 (2 commits)
2019-10-22 garyq@google.com Update harfbuzz to 2.6.2, Roll buildroot to a518e (flutter/engine#13242)
2019-10-22 ferhat@gmail.com Fix decode feature detection in HtmlCodec (flutter/engine#13274)
2019-10-22 chinmaygarde@google.com Avoid accessing the Cocoa view on the GPU or IO task runners. (flutter/engine#13295)
2019-10-22 gw280@google.com Make flutter_tester support multithreaded testing, and run all Dart tests in both single and multithreaded configurations (flutter/engine#13273)
2019-10-22 30870216+gaaclarke@users.noreply.github.com Made restarting the Engine remember the last entrypoint that was used. (flutter/engine#13289)
2019-10-22 skia-flutter-autoroll@skia.org Roll src/third_party/skia f3f8ac37e468..2638f3d44b02 (12 commits) (flutter/engine#13291)
2019-10-22 hterkelsen@users.noreply.github.com Flesh out the CanvasKit backend some more (flutter/engine#13275)
2019-10-22 rmacnak@google.com Roll Dart to 6a65ea9cad4b014f88d2f1be1b321db493725a1c. (flutter/engine#13294)
2019-10-22 chinmaygarde@google.com Disable flaky test ShellTest_ReportTimingsIsCalled. (flutter/engine#13292)
2019-10-22 jason-simmons@users.noreply.github.com Do not request executable permission on Fuchsia file mappings unless it is required (flutter/engine#13290)
2019-10-22 bkonyi@google.com Roll src/third_party/dart e1c409792c..5814319bf9 (9 commits)
2019-10-22 30870216+gaaclarke@users.noreply.github.com Revert "Made restarting the Engine remember the last entrypoint that was used. (flutter#13264)" (flutter/engine#13287)
2019-10-22 30870216+gaaclarke@users.noreply.github.com Made restarting the Engine remember the last entrypoint that was used. (flutter/engine#13264)


If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-engine-flutter-autoroll
Please CC aaclarke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franciscojma86 franciscojma86 franciscojma86 approved these changes

@gaaclarke gaaclarke gaaclarke approved these changes

@stuartmorgan stuartmorgan Awaiting requested review from stuartmorgan

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
4 participants
@chinmaygarde @franciscojma86 @gaaclarke @googlebot