This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Fix decode feature detection in HtmlCodec #13274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harryterkelsen
approved these changes
Oct 21, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 22, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 23, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 23, 2019
This was referenced Oct 23, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 23, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Oct 23, 2019
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Oct 23, 2019
git@github.com:flutter/engine.git/compare/a064063e3f63...b5a33d4 git log a064063..b5a33d4 --no-merges --oneline 2019-10-23 chinmaygarde@google.com Allow embedders to update preferrred locales. (flutter/engine#13238) 2019-10-23 jason-simmons@users.noreply.github.com Show strace logs when the Fuchsia gen_package script gets an error from the packaging tool (flutter/engine#13298) 2019-10-22 ferhat@gmail.com [web] Cupertino dynamic color fix. (flutter/engine#13296) 2019-10-22 bkonyi@google.com Roll src/third_party/dart 6a65ea9cad..4ab09db0f4 (2 commits) 2019-10-22 garyq@google.com Update harfbuzz to 2.6.2, Roll buildroot to a518e (flutter/engine#13242) 2019-10-22 ferhat@gmail.com Fix decode feature detection in HtmlCodec (flutter/engine#13274) 2019-10-22 chinmaygarde@google.com Avoid accessing the Cocoa view on the GPU or IO task runners. (flutter/engine#13295) 2019-10-22 gw280@google.com Make flutter_tester support multithreaded testing, and run all Dart tests in both single and multithreaded configurations (flutter/engine#13273) 2019-10-22 30870216+gaaclarke@users.noreply.github.com Made restarting the Engine remember the last entrypoint that was used. (flutter/engine#13289) 2019-10-22 skia-flutter-autoroll@skia.org Roll src/third_party/skia f3f8ac37e468..2638f3d44b02 (12 commits) (flutter/engine#13291) 2019-10-22 hterkelsen@users.noreply.github.com Flesh out the CanvasKit backend some more (flutter/engine#13275) 2019-10-22 rmacnak@google.com Roll Dart to 6a65ea9cad4b014f88d2f1be1b321db493725a1c. (flutter/engine#13294) 2019-10-22 chinmaygarde@google.com Disable flaky test ShellTest_ReportTimingsIsCalled. (flutter/engine#13292) 2019-10-22 jason-simmons@users.noreply.github.com Do not request executable permission on Fuchsia file mappings unless it is required (flutter/engine#13290) 2019-10-22 bkonyi@google.com Roll src/third_party/dart e1c409792c..5814319bf9 (9 commits) 2019-10-22 30870216+gaaclarke@users.noreply.github.com Revert "Made restarting the Engine remember the last entrypoint that was used. (#13264)" (flutter/engine#13287) 2019-10-22 30870216+gaaclarke@users.noreply.github.com Made restarting the Engine remember the last entrypoint that was used. (flutter/engine#13264) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Inconnu08
pushed a commit
to Inconnu08/flutter
that referenced
this pull request
Nov 26, 2019
git@github.com:flutter/engine.git/compare/a064063e3f63...b5a33d4 git log a064063..b5a33d4 --no-merges --oneline 2019-10-23 chinmaygarde@google.com Allow embedders to update preferrred locales. (flutter/engine#13238) 2019-10-23 jason-simmons@users.noreply.github.com Show strace logs when the Fuchsia gen_package script gets an error from the packaging tool (flutter/engine#13298) 2019-10-22 ferhat@gmail.com [web] Cupertino dynamic color fix. (flutter/engine#13296) 2019-10-22 bkonyi@google.com Roll src/third_party/dart 6a65ea9cad..4ab09db0f4 (2 commits) 2019-10-22 garyq@google.com Update harfbuzz to 2.6.2, Roll buildroot to a518e (flutter/engine#13242) 2019-10-22 ferhat@gmail.com Fix decode feature detection in HtmlCodec (flutter/engine#13274) 2019-10-22 chinmaygarde@google.com Avoid accessing the Cocoa view on the GPU or IO task runners. (flutter/engine#13295) 2019-10-22 gw280@google.com Make flutter_tester support multithreaded testing, and run all Dart tests in both single and multithreaded configurations (flutter/engine#13273) 2019-10-22 30870216+gaaclarke@users.noreply.github.com Made restarting the Engine remember the last entrypoint that was used. (flutter/engine#13289) 2019-10-22 skia-flutter-autoroll@skia.org Roll src/third_party/skia f3f8ac37e468..2638f3d44b02 (12 commits) (flutter/engine#13291) 2019-10-22 hterkelsen@users.noreply.github.com Flesh out the CanvasKit backend some more (flutter/engine#13275) 2019-10-22 rmacnak@google.com Roll Dart to 6a65ea9cad4b014f88d2f1be1b321db493725a1c. (flutter/engine#13294) 2019-10-22 chinmaygarde@google.com Disable flaky test ShellTest_ReportTimingsIsCalled. (flutter/engine#13292) 2019-10-22 jason-simmons@users.noreply.github.com Do not request executable permission on Fuchsia file mappings unless it is required (flutter/engine#13290) 2019-10-22 bkonyi@google.com Roll src/third_party/dart e1c409792c..5814319bf9 (9 commits) 2019-10-22 30870216+gaaclarke@users.noreply.github.com Revert "Made restarting the Engine remember the last entrypoint that was used. (flutter#13264)" (flutter/engine#13287) 2019-10-22 30870216+gaaclarke@users.noreply.github.com Made restarting the Engine remember the last entrypoint that was used. (flutter/engine#13264) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to check prototype of Image instead.