-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reland "fix fml_unittes is not run during presubmit (#13395)" #13426
Conversation
@@ -192,17 +192,19 @@ TEST(MessageLoopTaskQueue, ConcurrentQueueAndTaskCreatingCounts) { | |||
auto creation_func = [&] { | |||
for (int i = 0; i < num_queues; i++) { | |||
fml::TaskQueueId queue_id = task_queues->CreateTaskQueue(); | |||
created[queue_id - base_queue_id] = true; | |||
int limit = queue_id - base_queue_id; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chinmaygarde @iskakaushik This test is flaky. I cannot reproduce it locally, and luci fails some of the times with exit code of -6 or -11, which I cannot tell what causes it. Would you recommend me disable it? I prefer to get this merge as soon as possible since the entire fml test suite is skipped at the moment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me. Could you please file an issue and assign it to me. I will work on getting this re-enabled.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
flutter/flutter#42024