Reland "fix fml_unittes is not run during presubmit (#13395)" #13426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chunhtai
commented
Oct 30, 2019
| @@ -192,17 +192,19 @@ TEST(MessageLoopTaskQueue, ConcurrentQueueAndTaskCreatingCounts) { | |||
| auto creation_func = [&] { | |||
| for (int i = 0; i < num_queues; i++) { | |||
| fml::TaskQueueId queue_id = task_queues->CreateTaskQueue(); | |||
| created[queue_id - base_queue_id] = true; | |||
| int limit = queue_id - base_queue_id; | |||
There was a problem hiding this comment.
@chinmaygarde @iskakaushik This test is flaky. I cannot reproduce it locally, and luci fails some of the times with exit code of -6 or -11, which I cannot tell what causes it. Would you recommend me disable it? I prefer to get this merge as soon as possible since the entire fml test suite is skipped at the moment.
There was a problem hiding this comment.
Makes sense to me. Could you please file an issue and assign it to me. I will work on getting this re-enabled.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
flutter/flutter#42024