Use unified logging instead of syslog on iOS 13+ #13487

jmagman · 2019-11-02T00:51:53Z

Use os_log instead of syslog.

Fixes flutter/flutter#44030.

See also:
#3797
#3739
#3728
#3726
#3484
#3481

cbracken

fml/logging.cc

chinmaygarde

lgtm with nits.

fml/logging.cc

chinmaygarde · 2019-11-04T19:44:47Z

lib/ui/dart_runtime_hooks.cc

+    // provides more logging context, particularly for application crashes.
+    if (__builtin_available(iOS 13.0, macOS 10.11, *)) {
+      static os_log_t dart_log = os_log_create("io.flutter", "dart");
+      os_log(dart_log, "%.*s", (int)length, chars);


Please avoid C style casts in C++ TU's (I realize the old code ignored this guidance).

lib/ui/dart_runtime_hooks.cc

fml/logging.cc

cbracken · 2019-11-25T18:10:31Z

@jmagman ping for followup on @chinmaygarde 's comments. Other than those, this should be ready to go.

jmagman · 2019-12-03T01:09:09Z

lib/ui/dart_runtime_hooks.cc

+    // for application crashes.
+    if (__builtin_available(iOS 13.0, macOS 10.11, *)) {
+      os_log_t dart_log = os_log_create("io.flutter", "dart");
+      os_log(dart_log, "%.*s", @(length).intValue, chars);


@chinmaygarde

Please avoid C style casts in C++ TU's (I realize the old code ignored this guidance).

I created a NSNumber to avoid the cast but that seems overkill. The %.* needs to be an int, I don't see a way to pass an unsigned long as a width specifier.

Use a C++ style static_cast<int>(length) here instead.

cbracken

Re-approved modulo cast nit.

Migrates to using os_log for app logging on iOS 13 and above, macOS 10.11 and above. On older platform, fall back to syslog(), which is what we used previously.

Looks like somehow the fix to move to static_cast didn't get merged. This reverts commit 78a8909.

…6546) Looks like somehow the fix to move to static_cast didn't get merged. This reverts commit 78a8909.

…ne#13487)

* f49a8b6 Roll src/third_party/skia c03e6982f96f..465864cad5d2 (14 commits) (flutter/engine#16524) * c477c06 Enable verbose logging for shell unittests on Fuchsia (flutter/engine#16526) * a662579 Clear frame references at the end of every CanvasKit frame (flutter/engine#16525) * 3f31ea3 Roll src/third_party/skia 465864cad5d2..21f382c19d76 (6 commits) (flutter/engine#16528) * 38fb6b1 Roll fuchsia/sdk/core/linux-amd64 from 8L7NY... to Bmq1m... (flutter/engine#16529) * 9c0168a Roll fuchsia/sdk/core/mac-amd64 from PMcw3... to 7JkB7... (flutter/engine#16530) * e8a888d Roll src/third_party/skia 21f382c19d76..f83d0346c06a (2 commits) (flutter/engine#16532) * 1e8b331 Roll src/third_party/dart 5244d99a5d4e..5fc031ebc1d7 (42 commits) (flutter/engine#16533) * c4e3ae6 Roll src/third_party/skia f83d0346c06a..88c3793a4eaa (1 commits) (flutter/engine#16534) * 6cdb14e Roll src/third_party/skia 88c3793a4eaa..abefc9c170c9 (1 commits) (flutter/engine#16535) * 975acd8 Roll src/third_party/skia abefc9c170c9..4fe89b4d871d (2 commits) (flutter/engine#16536) * b7424d0 Roll src/third_party/dart 5fc031ebc1d7..30151a654151 (2 commits) (flutter/engine#16537) * 25e8127 Roll src/third_party/skia 4fe89b4d871d..dc2782c380f6 (1 commits) (flutter/engine#16538) * 74fa10c Roll src/third_party/dart 30151a654151..76b18c455e2c (1 commits) (flutter/engine#16539) * 91b8e40 Roll src/third_party/skia dc2782c380f6..cdf2491afa04 (1 commits) (flutter/engine#16540) * 5acf9b1 Roll src/third_party/skia cdf2491afa04..50a490a1a4fb (2 commits) (flutter/engine#16541) * 9897777 Roll src/third_party/skia 50a490a1a4fb..c3b67eb988c8 (4 commits) (flutter/engine#16542) * 78a8909 Use os_log instead of syslog on Apple platforms (flutter/engine#13487) * ea56ad2 libtxt: use a fixture in the benchmarks (flutter/engine#16531) * a61dbf2 Revert "Use os_log instead of syslog on Apple platforms (#13487)" (flutter/engine#16546) * 539f64f [fuchsia] Disable retained layers (flutter/engine#16548) * c3b5072 Expose DPI helper functions for Runner apps to use (flutter/engine#16313) * 5041ff1 support endless trace buffer (flutter/engine#16520) * 6aacf5e Re-land: Use os_log instead of syslog on Apple platforms (flutter/engine#16549) * a5736b8 Roll src/third_party/skia c3b67eb988c8..b1525c721ea6 (4 commits) (flutter/engine#16543) * 49a370f Roll src/third_party/dart 76b18c455e2c..e4c39721c473 (6 commits) (flutter/engine#16544) * 270421c Fix ensureInitializationCompleteAsync callback when already initialized. (#39675) (flutter/engine#16503) * ca02b91 Prevent long flash when switching to Flutter app. (#47903) (flutter/engine#16527) * 44e80fd skiping tests in Safari. LUCI recipe for Mac is ready. this is the only step left for stopping us running unit tests in Safari (flutter/engine#16550) * 5fb0116 iOS platform view gesture blocking policy. (flutter/engine#15940) * e0ebaea Revert "Re-land: Use os_log instead of syslog on Apple platforms (#16549)" (flutter/engine#16558)

…ne#13487)

* f49a8b6 Roll src/third_party/skia c03e6982f96f..465864cad5d2 (14 commits) (flutter/engine#16524) * c477c06 Enable verbose logging for shell unittests on Fuchsia (flutter/engine#16526) * a662579 Clear frame references at the end of every CanvasKit frame (flutter/engine#16525) * 3f31ea3 Roll src/third_party/skia 465864cad5d2..21f382c19d76 (6 commits) (flutter/engine#16528) * 38fb6b1 Roll fuchsia/sdk/core/linux-amd64 from 8L7NY... to Bmq1m... (flutter/engine#16529) * 9c0168a Roll fuchsia/sdk/core/mac-amd64 from PMcw3... to 7JkB7... (flutter/engine#16530) * e8a888d Roll src/third_party/skia 21f382c19d76..f83d0346c06a (2 commits) (flutter/engine#16532) * 1e8b331 Roll src/third_party/dart 5244d99a5d4e..5fc031ebc1d7 (42 commits) (flutter/engine#16533) * c4e3ae6 Roll src/third_party/skia f83d0346c06a..88c3793a4eaa (1 commits) (flutter/engine#16534) * 6cdb14e Roll src/third_party/skia 88c3793a4eaa..abefc9c170c9 (1 commits) (flutter/engine#16535) * 975acd8 Roll src/third_party/skia abefc9c170c9..4fe89b4d871d (2 commits) (flutter/engine#16536) * b7424d0 Roll src/third_party/dart 5fc031ebc1d7..30151a654151 (2 commits) (flutter/engine#16537) * 25e8127 Roll src/third_party/skia 4fe89b4d871d..dc2782c380f6 (1 commits) (flutter/engine#16538) * 74fa10c Roll src/third_party/dart 30151a654151..76b18c455e2c (1 commits) (flutter/engine#16539) * 91b8e40 Roll src/third_party/skia dc2782c380f6..cdf2491afa04 (1 commits) (flutter/engine#16540) * 5acf9b1 Roll src/third_party/skia cdf2491afa04..50a490a1a4fb (2 commits) (flutter/engine#16541) * 9897777 Roll src/third_party/skia 50a490a1a4fb..c3b67eb988c8 (4 commits) (flutter/engine#16542) * 78a8909 Use os_log instead of syslog on Apple platforms (flutter/engine#13487) * ea56ad2 libtxt: use a fixture in the benchmarks (flutter/engine#16531) * a61dbf2 Revert "Use os_log instead of syslog on Apple platforms (#13487)" (flutter/engine#16546) * 539f64f [fuchsia] Disable retained layers (flutter/engine#16548) * c3b5072 Expose DPI helper functions for Runner apps to use (flutter/engine#16313) * 5041ff1 support endless trace buffer (flutter/engine#16520) * 6aacf5e Re-land: Use os_log instead of syslog on Apple platforms (flutter/engine#16549) * a5736b8 Roll src/third_party/skia c3b67eb988c8..b1525c721ea6 (4 commits) (flutter/engine#16543) * 49a370f Roll src/third_party/dart 76b18c455e2c..e4c39721c473 (6 commits) (flutter/engine#16544) * 270421c Fix ensureInitializationCompleteAsync callback when already initialized. (#39675) (flutter/engine#16503) * ca02b91 Prevent long flash when switching to Flutter app. (#47903) (flutter/engine#16527) * 44e80fd skiping tests in Safari. LUCI recipe for Mac is ready. this is the only step left for stopping us running unit tests in Safari (flutter/engine#16550) * 5fb0116 iOS platform view gesture blocking policy. (flutter/engine#15940) * e0ebaea Revert "Re-land: Use os_log instead of syslog on Apple platforms (#16549)" (flutter/engine#16558) * 8a6b949 [Fuchsia] Dump syslog output after tests have run (flutter/engine#16561) * bca879c Roll src/third_party/dart e4c39721c473..0299903f3e78 (31 commits) (flutter/engine#16553) * cd11d7a Roll fuchsia/sdk/core/mac-amd64 from 7JkB7... to t4kck... (flutter/engine#16555) * 99a265b [web] Fix edge cases in Paragraph.getPositionForOffset to match Flutter (flutter/engine#16557) * 8f8af1f Update felt documentation (flutter/engine#16559) * 13dce50 Roll src/third_party/skia b1525c721ea6..67da665c27ff (32 commits) (flutter/engine#16562) * 7c67573 Fix multiline Javadoc code blocks (flutter/engine#16565) * aece5ad Move log_listener call into the reboot trap (flutter/engine#16564) * 42f18d9 Roll src/third_party/skia 67da665c27ff..886e8500a9f2 (3 commits) (flutter/engine#16566) * c4c6ef6 Samsung keyboard duplication workaround: updateSelection (flutter/engine#16547) * 15062ca Revert "Re-arm timer as necessary in MessageLoopFuchsia" (flutter/engine#16568) * 8802a1d Roll src/third_party/skia 886e8500a9f2..9102c86a81ad (1 commits) (flutter/engine#16570) * dbdcae4 Roll src/third_party/skia 9102c86a81ad..6029cbd560b7 (2 commits) (flutter/engine#16575) * f39bc73 Exposes FlutterSurfaceView, and FlutterTextureView to FlutterActivity and FlutterFragment. (#41984, #47557) (flutter/engine#16552) * db030ec Roll src/third_party/skia 6029cbd560b7..1a733b5b760a (1 commits) (flutter/engine#16577) * 050d29d Roll src/third_party/skia 1a733b5b760a..1d1333fcedf8 (3 commits) (flutter/engine#16578) * 97fd898 Roll fuchsia/sdk/core/mac-amd64 from t4kck... to oHa-O... (flutter/engine#16581) * 2e67866 Roll src/third_party/skia 1d1333fcedf8..3bf3b92dfab0 (1 commits) (flutter/engine#16584)

Migrates to using os_log for app logging on iOS 13 and above, macOS 10.11 and above. On older platform, fall back to syslog(), which is what we used previously.

…" (flutter#16546) Looks like somehow the fix to move to static_cast didn't get merged. This reverts commit 78a8909.

…ter#13487)" (flutter#16546)" This reverts commit 01b6df7.

This reverts commit f812056.

jmagman requested review from chinmaygarde and cbracken November 2, 2019 00:51

googlebot added the cla: yes label Nov 2, 2019

cbracken approved these changes Nov 4, 2019

View reviewed changes

cbracken reviewed Nov 4, 2019

View reviewed changes

fml/logging.cc Outdated Show resolved Hide resolved

chinmaygarde approved these changes Nov 4, 2019

View reviewed changes

jmagman force-pushed the logging branch from a29e186 to 98edc00 Compare December 2, 2019 21:55

jmagman changed the title ~~Use unified logging instead of syslog on iOS 13+~~ WIP Use unified logging instead of syslog on iOS 13+ Dec 2, 2019

jmagman changed the title ~~WIP Use unified logging instead of syslog on iOS 13+~~ Use unified logging instead of syslog on iOS 13+ Dec 2, 2019

jmagman commented Dec 3, 2019

View reviewed changes

cbracken approved these changes Dec 5, 2019

View reviewed changes

Use os_log instead of syslog on Apple platforms

3c2b2fc

Migrates to using os_log for app logging on iOS 13 and above, macOS 10.11 and above. On older platform, fall back to syslog(), which is what we used previously.

cbracken force-pushed the logging branch from 2b44043 to 3c2b2fc Compare January 25, 2020 01:24

cbracken added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Feb 11, 2020

cbracken merged commit 78a8909 into flutter:master Feb 11, 2020

cbracken added a commit to cbracken/flutter_engine that referenced this pull request Feb 11, 2020

Revert "Use os_log instead of syslog on Apple platforms (flutter#13487)"

09e9326

Looks like somehow the fix to move to static_cast didn't get merged. This reverts commit 78a8909.

cbracken added a commit that referenced this pull request Feb 11, 2020

Revert "Use os_log instead of syslog on Apple platforms (#13487)" (#1…

a61dbf2

…6546) Looks like somehow the fix to move to static_cast didn't get merged. This reverts commit 78a8909.

engine-flutter-autoroll mentioned this pull request Feb 12, 2020

Roll engine 0e8ed2715a35..5041ff1b1e37 (23 commits) flutter/flutter#50667

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 12, 2020

78a8909 Use os_log instead of syslog on Apple platforms (flutter/engi…

77d32c6

…ne#13487)

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 12, 2020

78a8909 Use os_log instead of syslog on Apple platforms (flutter/engi…

929bdba

…ne#13487)

engine-flutter-autoroll mentioned this pull request Feb 12, 2020

Roll engine 0e8ed2715a35..e0ebaea59071 (31 commits) flutter/flutter#50671

Merged

engine-flutter-autoroll mentioned this pull request Feb 14, 2020

Roll engine 0e8ed2715a35..2e6786621f7b (49 commits) flutter/flutter#50803

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 14, 2020

78a8909 Use os_log instead of syslog on Apple platforms (flutter/engi…

0d7b662

…ne#13487)

NoamDev pushed a commit to NoamDev/engine that referenced this pull request Feb 27, 2020

Revert "Use os_log instead of syslog on Apple platforms (flutter#13487)…

01b6df7

…" (flutter#16546) Looks like somehow the fix to move to static_cast didn't get merged. This reverts commit 78a8909.

NoamDev added a commit to NoamDev/engine that referenced this pull request Feb 27, 2020

Revert "Revert "Use os_log instead of syslog on Apple platforms (flut…

d6aa49f

…ter#13487)" (flutter#16546)" This reverts commit 01b6df7.

NoamDev added a commit to NoamDev/engine that referenced this pull request Feb 27, 2020

Revert "Use os_log instead of syslog on Apple platforms (flutter#13487)"

53218fa

This reverts commit f812056.

jmagman mentioned this pull request Jun 3, 2020

[flutter_tools] iOS VM Service logs should include stderr flutter/flutter#58551

Merged

cbracken mentioned this pull request Apr 2, 2021

Use unified logging instead of syslog on iOS 13+ flutter/flutter#44030

Open

jmagman deleted the logging branch June 17, 2024 20:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use unified logging instead of syslog on iOS 13+ #13487

Use unified logging instead of syslog on iOS 13+ #13487

jmagman commented Nov 2, 2019

cbracken left a comment

chinmaygarde left a comment

chinmaygarde Nov 4, 2019

cbracken commented Nov 25, 2019

jmagman Dec 3, 2019

cbracken Dec 5, 2019

cbracken left a comment

Use unified logging instead of syslog on iOS 13+ #13487

Use unified logging instead of syslog on iOS 13+ #13487

Conversation

jmagman commented Nov 2, 2019

cbracken left a comment

Choose a reason for hiding this comment

chinmaygarde left a comment

Choose a reason for hiding this comment

chinmaygarde Nov 4, 2019

Choose a reason for hiding this comment

cbracken commented Nov 25, 2019

jmagman Dec 3, 2019

Choose a reason for hiding this comment

cbracken Dec 5, 2019

Choose a reason for hiding this comment

cbracken left a comment

Choose a reason for hiding this comment