[fuchsia] Package flutter_frontend_server snapshot for fuchsia #13865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aam
reviewed
Nov 14, 2019
|
|
||
| inputs = frontend_server_files | ||
| application_snapshot("frontend_server") { |
There was a problem hiding this comment.
Aren't you going to end up with two frontend_server app snapshots defined in fuchsia setting - one defined here, second defined at line 37?
There was a problem hiding this comment.
This target will not be invoked in fuchsia tree. So we should end up with only one. For context: none of the targets other that the one above are invoked in Fuchsia tree currently.
There was a problem hiding this comment.
What was the motivation to move these out of of else branch guarded by is_fuchsia then?
There was a problem hiding this comment.
There are a few things going on here:
- When we build for Fuchsia target from the flutter tree,
is_fuchsiais set to true. Which means that this needs to be outside the else block. - Though the target above is in
is_fuchsiablock, it is not invoked because the root of all the targets for Fuchsia builds in the engine tree is https://github.com/flutter/engine/blob/master/shell/platform/fuchsia/BUILD.gn#L68
There was a problem hiding this comment.
Okay, talked offline. It's a temporary thing until fuchsia stops building flutter_frontend_server itself, instead uses app snapshot that is built by flutter engine and gets packaged for fuchsia consumption.
aam
approved these changes
Nov 14, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 15, 2019
This was referenced Nov 15, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 15, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 15, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 15, 2019
This was referenced Nov 15, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 15, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 15, 2019
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 15, 2019
flar
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 15, 2019
* 174e0e9 Roll src/third_party/dart dc35290111..dc808f3fcb (5 commits) (flutter/engine#13859) * 33d997c Roll fuchsia/sdk/core/mac-amd64 from 7XOyl... to VMTIz... (flutter/engine#13861) * b4899d9 Roll src/third_party/skia d860a78fd60c..e57ca4931952 (44 commits) (flutter/engine#13862) * f456423 RendererContextSwitch guard flutter's gl context rework. (flutter/engine#13812) * 6bab64e Fix test to account for pixel ratio transformations being framework responsibility. (flutter/engine#13850) * 5b10fa3 Guard against orphaned semantic objects from referencing dead accessibility bridge on iOS (flutter/engine#13857) * 97df087 [fuchsia] Package flutter_frontend_server snapshot for fuchsia (flutter/engine#13865) * 0832dfd [flow][fuchsia] Add more tracing to layers and Fuchsia surface pool (flutter/engine#13864) * 141dc785d Roll src/third_party/skia e57ca4931952..c1c4634dcb07 (15 commits) (flutter/engine#13866) * 90a6054 Revert "Roll src/third_party/dart dc35290111..dc808f3fcb (5 commits) (#13859)" (flutter/engine#13867)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.