Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fallback to Roboto if no suitable font is found" #14071

Closed
wants to merge 1 commit into from

Conversation

Copy link
Contributor

@liyuqian liyuqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harryterkelsen
Copy link
Contributor

That test should not be hitting the Roboto fallback code. That code should only be live if the FLUTTER_WEB_USE_SKIA environment variable is set to true

@liyuqian
Copy link
Contributor

liyuqian commented Dec 2, 2019

Then maybe something in our test infra is going wrong? @zanderso : maybe let's revert the engine roll first (flutter/flutter#45916) to see if the failure goes away. If not, then it's definitely an infra issue. CC @digiter @godofredoc .

@zanderso
Copy link
Member Author

zanderso commented Dec 2, 2019

kk landed the engine roll revert.

@zanderso
Copy link
Member Author

zanderso commented Dec 2, 2019

@liyuqian will you pause the roller?

@liyuqian
Copy link
Contributor

liyuqian commented Dec 2, 2019

@zanderso : paused now. Please feel free to resume it on https://autoroll.skia.org/r/flutter-engine-flutter-autoroll?tab=status once the root cause (either the infra issue or the engine commit) is fixed.

@zanderso
Copy link
Member Author

zanderso commented Dec 2, 2019

@hterkelsen @liyuqian the bot turned green after the engine revert. Other failures on the engine roll appear to be infra related, but I'm not sure about this one. @hterkelsen can you run the test locally with your change.

@harryterkelsen
Copy link
Contributor

I just ran flutter test --local-engine=host_debug_unopt test/material with a tip-of-tree engine build and the tests are all passing

@harryterkelsen
Copy link
Contributor

It looks like the failing test isn't even running on web.

@zanderso
Copy link
Member Author

zanderso commented Dec 2, 2019

Okay. When the dashboard recovers from some other issues and turns green, I will re-enable the engine roller.

@zanderso zanderso closed this Dec 2, 2019
@zanderso zanderso deleted the revert-14061-canvaskit-fix-crashing-text branch December 2, 2019 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants