-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Fallback to Roboto if no suitable font is found" #14071
Conversation
This reverts commit 8d6fa7e.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
That test should not be hitting the Roboto fallback code. That code should only be live if the |
Then maybe something in our test infra is going wrong? @zanderso : maybe let's revert the engine roll first (flutter/flutter#45916) to see if the failure goes away. If not, then it's definitely an infra issue. CC @digiter @godofredoc . |
kk landed the engine roll revert. |
@liyuqian will you pause the roller? |
@zanderso : paused now. Please feel free to resume it on https://autoroll.skia.org/r/flutter-engine-flutter-autoroll?tab=status once the root cause (either the infra issue or the engine commit) is fixed. |
@hterkelsen @liyuqian the bot turned green after the engine revert. Other failures on the engine roll appear to be infra related, but I'm not sure about this one. @hterkelsen can you run the test locally with your change. |
I just ran |
It looks like the failing test isn't even running on web. |
Okay. When the dashboard recovers from some other issues and turns green, I will re-enable the engine roller. |
Reverts #14061
Failure of CI test https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket.appspot.com/8895404291158004192/+/steps/run_test.dart_for_framework_tests_shard/0/stdout?format=raw