Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback to Roboto if no suitable font is found #14061

Merged

Conversation

harryterkelsen
Copy link
Contributor

Downloads Roboto unless it has already been included in the assets. Also, if the font family requested wasn't one of the ones that was registered, then use Roboto.

Copy link
Member

@jonahwilliams jonahwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

is it possible to get a small unit test for this behavior?

@harryterkelsen
Copy link
Contributor Author

We unfortunately don't have the infrastructure to test the CanvasKit backend currently

@harryterkelsen harryterkelsen merged commit 8d6fa7e into flutter:master Nov 28, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Nov 29, 2019
skia-flutter-autoroll pushed a commit to flutter/flutter that referenced this pull request Nov 30, 2019
* 8d6fa7e Fallback to Roboto if no suitable font is found (flutter/engine#14061)

* 8672e79 Roll src/third_party/skia c96f5108df28..73beaaa48fcc (2 commits) (flutter/engine#14065)
zanderso added a commit that referenced this pull request Dec 2, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants