-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Started specifying the OS version for running the tests. #14094
Conversation
I wonder what's the motivation of this change? If there's an issue, maybe a link to it would be helpful. |
Added. We should always specify the OS version the golden tests are meant to be run on since changes in OS's can break golden tests. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - we'll need to update this periodically though, e.g. when we want to update https://github.com/flutter/infra/blob/master/config/main.star#L254 and it no longer includes this version.
I downgraded the OS version to 12.2 since @dnfield told me we are running Xcode 10.2 on the testing machines which means it should have the simulator for 12.2 already installed (https://developer.apple.com/documentation/ios_ipados_release_notes/ios_12_2_release_notes?language=objc). |
Heads up, we are already going to run into troubles because we are using iPhone SE. On Xcode 11+ that is no longer a standard simulator target. Higher versions of Xcode can test on lower versions, you just have to go through the effort to setup and install the simulators. |
Verified the change in luci build: https://ci.chromium.org/swarming/task/48ec2fcae723a110?server=chromium-swarm.appspot.com |
relevant issue: flutter/flutter#46120