Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ios] Allow for iOS version slack for scenarios tests #18562

Conversation

iskakaushik
Copy link
Contributor

This is equivalent to having OS=latest which allows one
to pick the latest available OS version on the host system
rather than enforcing a strict match of 13.0

This is equivalent to having OS=latest which allows one
to pick the latest available OS version on the host system
rather than enforcing a strict match of 13.0
@dnfield
Copy link
Contributor

dnfield commented May 21, 2020

I was under the impression we needed to pin the version because the golden testing we do on here for iOS can change from OS version to OS version. I'm a little worried that this will cause CI breakages when a toolchain rolls and it won't be obvious as to why. Any ideas about what we can do about that?

@dnfield
Copy link
Contributor

dnfield commented May 21, 2020

/cc @LongCatIsLooong who did some work around updating this last time IIRC

@LongCatIsLooong
Copy link
Contributor

I had to bump the simulator version for xcode 11 because there was no iPhone SE simulator by default in xcode 11, so I had to change it to iPhone 8. That would have been caught even if "OS" was not specified.

It seems "OS" was added in this PR because the golden images changed between OS versions?

Copy link
Member

@gaaclarke gaaclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea like @dnfield said we have to be explicit here since the goldens won't match across operating system versions. You can install old versions of the simulator in Xcode. If you need help let me know.

@iskakaushik
Copy link
Contributor Author

No, I was hoping that this would be a welcome change given the overhead of installing a specific version of the simulator. I am happy with leaving it as is if goldens require a specific version. Closing this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants