Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web] [tests] Changing configurations for firefox #14148

Merged
merged 4 commits into from
Dec 5, 2019

Conversation

nturgut
Copy link
Contributor

@nturgut nturgut commented Dec 5, 2019

The configurations for firefox is added. Previously only chrome related conf. was loaded this was causing firefox to break on "felt test browser=firefox"

New prefs are added to firefox:

  • dom.disable_beforeunload=true: firefox does not show a popup for default browser
  • toolkit.startup.max_resumed_crashes=999999: firefox does not show a popup after browser crash

related to issue: flutter/flutter#44959

@nturgut nturgut removed the request for review from cbracken December 5, 2019 21:07
lib/web_ui/dart_test_firefox.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@mdebbar mdebbar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nturgut nturgut merged commit 91ef612 into flutter:master Dec 5, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 6, 2019
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Dec 6, 2019
filmil pushed a commit to filmil/engine that referenced this pull request Mar 13, 2020
* Changing configurations for firefox

* remove headless

* change comments on configurations files

* remove unused boolean
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants