Move Fuchsia unit test runners into engine repo (#14092) #14287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tvolkert
commented
Dec 10, 2019
tvolkert
commented
- Copies fuchsia_test.sh into the testing/fuchsia directory
- Fixes a small issue with fuchsia_archive to ensure the cmx file is correctly named according to the target
- Add a list of fuchsia unittest fars to run on CI
- Add a GN build target to build all currently-enabled unittests for Fuchsia
- Copies fuchsia_test.sh into the testing/fuchsia directory - Fixes a small issue with fuchsia_archive to ensure the cmx file is correctly named according to the target - Add a list of fuchsia unittest fars to run on CI - Add a GN build target to build all currently-enabled unittests for Fuchsia
gw280
reviewed
Dec 10, 2019
BUILD.gn
Outdated
| testonly = true | ||
|
|
||
| deps = [ | ||
| "$flutter_root/flow:flow_tests", |
There was a problem hiding this comment.
You will need to remove this dep as this branch doesn't have the flow_tests added.
gw280
approved these changes
Dec 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.