-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Fuchsia unit test runners into engine repo (#14092) #14287
Merged
tvolkert
merged 2 commits into
flutter:v1.12.13-hotfixes
from
tvolkert:v1.12.13-hotfixes
Dec 10, 2019
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
#!/bin/bash | ||
|
||
# This expects the device to be in zedboot mode, with a zedboot that is | ||
# is compatible with the Fuchsia system image provided. | ||
# | ||
# The first and only parameter should be the path to the Fuchsia system image | ||
# tarball, e.g. `./fuchsia-test.sh generic-x64.tgz`. | ||
# | ||
# This script expects `pm`, `dev_finder`, and `fuchsia_ctl` to all be in the | ||
# same directory as the script, as well as the `flutter_aot_runner-0.far` and | ||
# the `flutter_runner_tests-0.far`. It is written to be run from its own | ||
# directory, and will fail if run from other directories or via sym-links. | ||
|
||
set -Ee | ||
|
||
# The nodes are named blah-blah--four-word-fuchsia-id | ||
device_name=${SWARMING_BOT_ID#*--} | ||
|
||
if [ -z "$device_name" ] | ||
then | ||
echo "No device found. Aborting." | ||
exit 1 | ||
else | ||
echo "Connecting to device $device_name" | ||
fi | ||
|
||
reboot() { | ||
# note: this will set an exit code of 255, which we can ignore. | ||
./fuchsia_ctl -d $device_name ssh -c "dm reboot-recovery" || true | ||
} | ||
|
||
trap reboot EXIT | ||
|
||
./fuchsia_ctl -d $device_name pave -i $1 | ||
|
||
# TODO(gw280): Enable tests using JIT runner | ||
./fuchsia_ctl -d $device_name test \ | ||
-f flutter_aot_runner-0.far \ | ||
-f flutter_runner_tests-0.far \ | ||
-t flutter_runner_tests | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
flutter_runner_tests-0.far |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You will need to remove this dep as this branch doesn't have the flow_tests added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done