[libtxt] Assign a unique ID to each glyph cluster within a line #15742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously layout had been using the cluster index returned by Minikin, which is only unique within each call to Minikin layout. This can produce duplicate cluster IDs within a line containing multiple text runs. GetGlyphPositionAtCoordinate then returns incorrect results because it thinks the affected glyphs are part of the same cluster. Fixes flutter/flutter#48231 Fixes flutter/flutter#49044
jason-simmons
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 23, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 23, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 23, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 23, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 23, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 24, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 24, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 24, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 24, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 24, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jan 24, 2020
engine-flutter-autoroll
added a commit
to flutter/flutter
that referenced
this pull request
Jan 24, 2020
flutter/engine@46e58b9...439a218 git log 46e58b9..439a218 --first-parent --oneline 2020-01-23 zhongwuzw@qq.com Fixes labelPrefix memory leak in FlutterEngine (flutter/engine#14674) 2020-01-23 matthew-carroll@users.noreply.github.com Release TextureView surface within FlutterTextureView when disconnected. (#48535) (flutter/engine#15899) 2020-01-23 iska.kaushik@gmail.com [fuchsia] Timeline events in profile mode to observatory (flutter/engine#15900) 2020-01-23 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from N502w... to Wc7e4... (flutter/engine#15935) 2020-01-23 tvolkert@users.noreply.github.com Add script to force build LUCI builders for a specified commit (flutter/engine#15938) 2020-01-23 skia-flutter-autoroll@skia.org Roll src/third_party/dart 6aa7407d6309..e84bea25df23 (6 commits) (flutter/engine#15934) 2020-01-23 skia-flutter-autoroll@skia.org Roll src/third_party/skia f9aea7f7e502..e4ddb8a7cddc (35 commits) (flutter/engine#15931) 2020-01-23 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from LGwl3... to LAOYs... (flutter/engine#15930) 2020-01-23 skia-flutter-autoroll@skia.org Roll src/third_party/dart 582727a4ec3b..6aa7407d6309 (4 commits) (flutter/engine#15923) 2020-01-23 gw280@google.com Revert "Migrate flutter_runner from flutter_runner::{Thread,Loop} to fml::{Thread,MessageLoop} (#15118)" (flutter/engine#15903) 2020-01-23 skia-flutter-autoroll@skia.org Roll src/third_party/dart a9ea9365ad8a..582727a4ec3b (33 commits) (flutter/engine#15906) 2020-01-22 brianosman@google.com Implement new SkCanvas virtuals in testing canvases (flutter/engine#15893) 2020-01-22 dnfield@google.com Const finder fixes (flutter/engine#15880) 2020-01-22 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/linux-amd64 from v-OJE... to N502w... (flutter/engine#15892) 2020-01-22 dnfield@google.com errant log (flutter/engine#15891) 2020-01-22 skia-flutter-autoroll@skia.org Roll src/third_party/skia d59053987a27..f9aea7f7e502 (10 commits) (flutter/engine#15890) 2020-01-22 jason-simmons@users.noreply.github.com [libtxt] Assign a unique ID to each glyph cluster within a line (flutter/engine#15742) 2020-01-22 skia-flutter-autoroll@skia.org Roll src/third_party/dart 439cabaec02f..a9ea9365ad8a (4 commits) (flutter/engine#15886) 2020-01-22 skia-flutter-autoroll@skia.org Roll fuchsia/sdk/core/mac-amd64 from jAkm1... to LGwl3... (flutter/engine#15884) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC aaclarke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md
NoamDev
pushed a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
NoamDev
added a commit
to NoamDev/engine
that referenced
this pull request
Feb 27, 2020
…ne (flutter#15742)" This reverts commit 4ac4153.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously layout had been using the cluster index returned by Minikin,
which is only unique within each call to Minikin layout. This can produce
duplicate cluster IDs within a line containing multiple text runs.
GetGlyphPositionAtCoordinate then returns incorrect results because it thinks
the affected glyphs are part of the same cluster.
Fixes flutter/flutter#48231
Fixes flutter/flutter#49044