Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc fixes in BoxHeightStyle #16424

Merged
merged 1 commit into from
Feb 7, 2020
Merged

Doc fixes in BoxHeightStyle #16424

merged 1 commit into from
Feb 7, 2020

Conversation

goderbauer
Copy link
Member

I think RectHeightStyle is supposed to be BoxHeightStyle in the docs?

@goderbauer
Copy link
Member Author

/cc @GaryQian

GaryQian
GaryQian approved these changes Feb 5, 2020
View reviewed changes
Copy link
Contributor

@GaryQian GaryQian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for catching that... so obvious in hindsight...

@goderbauer goderbauer added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Feb 5, 2020
@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Windows Host Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Feb 5, 2020
@goderbauer
Copy link
Member Author

Looks like the re-run is green: https://ci.chromium.org/p/flutter/builders/try/Windows%20Host%20Engine/3858

@goderbauer goderbauer merged commit e4f46f3 into flutter:master Feb 7, 2020
@goderbauer goderbauer deleted the docFixesBoxHeightStyle branch February 7, 2020 21:41
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Feb 8, 2020
@engine-flutter-autoroll
e4f46f3 Doc fixes in BoxHeightStyle (flutter/engine#16424)
ca981e8
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Feb 8, 2020
Merged
NoamDev pushed a commit to NoamDev/engine that referenced this pull request Feb 27, 2020
@goderbauer @NoamDev
Doc fixes in BoxHeightStyle (flutter#16424)
094c931
NoamDev added a commit to NoamDev/engine that referenced this pull request Feb 27, 2020
@NoamDev
Revert "Doc fixes in BoxHeightStyle (flutter#16424)"
182ad9f 
This reverts commit 094c931.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GaryQian GaryQian GaryQian approved these changes

@franciscojma86 franciscojma86 Awaiting requested review from franciscojma86

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@goderbauer @fluttergithubbot @GaryQian @googlebot