Started deleting .DS_Store files so licenses can run on mac os x. #16998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnfield
approved these changes
Mar 6, 2020
I don't think so. I looked into changing the script to ignore them but it seemed contrary to the script to ignore files for processing since it wants to check everything for license problems. |
dnfield
reviewed
Mar 7, 2020
| @@ -10,7 +10,7 @@ exitStatus=0 | |||
| dart --version | |||
|
|
|||
| # These files trip up the script on Mac OS X. | |||
| find . -name ".DS_Store" | xargs rm | |||
| find . -name ".DS_Store" -exec rm {} \; | |||
There was a problem hiding this comment.
uber-nit: you can just do -delete.
There was a problem hiding this comment.
right on, i would change it but end of day and ci takes forever
There was a problem hiding this comment.
Don't you need quotes to deal with paths with spaces here?
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 7, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 7, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 7, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 7, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 7, 2020
cbracken
pushed a commit
to flutter/flutter
that referenced
this pull request
Mar 7, 2020
* 7c612de Roll fuchsia/sdk/core/linux-amd64 from cXgMr... to cTw2C... (flutter/engine#16970) * 6cfa7fc fix shadows and mask filter blurs (flutter/engine#16963) * bfebadf Roll src/third_party/skia 012f8497802e..93a2a6b8badb (4 commits) (flutter/engine#16974) * 47963a5 Roll src/third_party/skia 93a2a6b8badb..74055566bd14 (2 commits) (flutter/engine#16981) * 98f9941 [fuchsia] fix broken flows when under high load (flutter/engine#16834) * fe051e0 Fix issue viewdidload call while init FlutterViewController (flutter/engine#16672) * 0ad54c2 [web] Fixes IE11 crash due to missing canvas ellipse support and font polyfill failure (flutter/engine#16965) * f6435de Roll fuchsia/sdk/core/mac-amd64 from J6ct_... to 95geB... (flutter/engine#16982) * 43971ca Roll src/third_party/skia 74055566bd14..54de2fa48d85 (3 commits) (flutter/engine#16983) * 45e61a6 Roll fuchsia/sdk/core/linux-amd64 from cTw2C... to K1wwe... (flutter/engine#16984) * 1ab5c36 Roll src/third_party/skia 54de2fa48d85..beaaf4700f50 (3 commits) (flutter/engine#16987) * e2c0454 remove 10s timeouts from tests (flutter/engine#16988) * dfc9c12 Roll src/third_party/skia beaaf4700f50..6e58290ba639 (9 commits) (flutter/engine#16990) * eddda80 fushia licenses fix (flutter/engine#16992) * c15f239 documented fluttertexture.h (flutter/engine#16950) * e1ba7a1 Roll src/third_party/skia 6e58290ba639..24a8e9e170f7 (5 commits) (flutter/engine#16996) * fc5963d [web] Engine integration test (flutter/engine#16930) * d323bac doxygen tooling updates and doxygen for FlutterCodecs.h (flutter/engine#16947) * 03ddc1d Started deleting .DS_Store files so licenses can run on mac os x. (flutter/engine#16998) * 30a8292 Roll src/third_party/skia 24a8e9e170f7..cf573d844da6 (4 commits) (flutter/engine#17004) * d031963 Roll fuchsia/sdk/core/mac-amd64 from 95geB... to hW33F... (flutter/engine#17006) * 41b371d Roll fuchsia/sdk/core/linux-amd64 from K1wwe... to FGMpI... (flutter/engine#17007) * 619acd5 Revert "fix shadows and mask filter blurs (#16963)" (flutter/engine#17008)
blasten
pushed a commit
to blasten/engine
that referenced
this pull request
Mar 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.