Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Started deleting .DS_Store files so licenses can run on mac os x. #16998

Merged
merged 2 commits into from Mar 7, 2020
Merged

Started deleting .DS_Store files so licenses can run on mac os x. #16998

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d676a2
Started deleting .DS_Store files so licenses can run on mac os x.
gaaclarke Mar 6, 2020
170a11e
switched away from xargs for the case there are no files
gaaclarke Mar 6, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions ci/licenses.sh
View file
Open in desktop
Expand Up @@ -9,6 +9,9 @@ exitStatus=0

dart --version

# These files trip up the script on Mac OS X.
find . -name ".DS_Store" -exec rm {} \;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uber-nit: you can just do -delete.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right on, i would change it but end of day and ci takes forever

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you need quotes to deal with paths with spaces here?


(cd flutter/tools/licenses; pub get; dart --enable-asserts lib/main.dart --src ../../.. --out ../../../out/license_script_output --golden ../../ci/licenses_golden)

for f in out/license_script_output/licenses_*; do
Expand Down