-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More rename from GPU thread to raster thread #17408
Conversation
GPUTaskRunner -> RasterTaskRunner gpu_task_runner -> raster_task_runner
gpu_thread -> raster_thread GpuThread -> RasterThread (These include filename changes)
868a228
to
e760de3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I marked the outdated comments I noticed. I am sure there are others but we can update those those as we notice them. Let's land this ASAP to prevent merge conflicts for a patch of this surface area.
// threads are the same, should_post_gpu_task will be false, and then instead | ||
// of posting a task to the raster thread, the ui thread just signals the | ||
// latch and the platform/raster thread follows with executing gpu_task. | ||
bool should_post_gpu_task = task_runners_.GetRasterTaskRunner() != |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing var update.
@@ -721,24 +721,24 @@ void Shell::OnPlatformViewDestroyed() { | |||
// gpu_task to the raster thread triggers signaling the latch(on the IO | |||
// thread). If the GPU the and platform threads are the same this results in a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment uses the old names still.
// the GPU and platform threads. Reduces the lease term by 1. | ||
GpuThreadStatus DecrementLease(); | ||
// Returns |RasterThreadStatus::kUnmergedNow| if this call resulted in | ||
// splitting the GPU and platform threads. Reduces the lease term by 1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Outdated thread name in comment.
@@ -190,7 +190,7 @@ SceneHost::SceneHost(fml::RefPtr<zircon::dart::Handle> viewHolderToken, | |||
|
|||
// Pass the raw handle to the GPU thead; destroying a |zircon::dart::Handle| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Outdated thread name in comment.
@@ -117,7 +117,7 @@ Dart_Handle Picture::RasterizeToImage(sk_sp<SkPicture> picture, | |||
|
|||
// Kick things off on the GPU. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"on the raster task runner"
@@ -721,24 +721,24 @@ void Shell::OnPlatformViewDestroyed() { | |||
// gpu_task to the raster thread triggers signaling the latch(on the IO | |||
// thread). If the GPU the and platform threads are the same this results in a | |||
// deadlock as the gpu_task will never be posted to the plaform/raster thread | |||
// that is blocked on a latch. To avoid the described deadlock, if the gpu | |||
// that is blocked on a latch. To avoid the described deadlock, if the raster | |||
// and the platform threads are the same, should_post_gpu_task will be false, | |||
// and then instead of posting a task to the raster thread, the ui thread just | |||
// signals the latch and the platform/raster thread follows with executing | |||
// gpu_task. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
raster_task
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice -- agreed with Chinmay; you may want to merge sooner rather than later to avoid conflicts, then land a cleanup.
Thanks! I'll merge this as is to avoid conflict, and address Chinmay's comment in another PR. |
This PR touches variable names, class names, and file names so it's significantly more risky than its predecessor flutter#17329 Due to file name changes, this PR is expected to change the license files. We haven't rename `shell/gpu` to `shell/raster` yet. It should be optional but I think it's better to have `raster_surface_software.cc` than `gpu_surface_software.cc`.
This PR touches variable names, class names, and file names so it's significantly more risky than its predecessor #17329
Due to file name changes, this PR is expected to change the license files.
We haven't rename
shell/gpu
toshell/raster
yet. It should be optional but I think it's better to haveraster_surface_software.cc
thangpu_surface_software.cc
.