Rename GPU thread to raster thread in code comments #17329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace "GPU([\n\r\s]+//+ thread)" with "raster$1"
liyuqian
requested review from
chinmaygarde,
cbracken and
filiph
and removed request for
stuartmorgan
chinmaygarde
approved these changes
Mar 25, 2020
cbracken
approved these changes
Mar 25, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Mar 26, 2020
liyuqian
added a commit
that referenced
this pull request
Mar 31, 2020
This PR touches variable names, class names, and file names so it's significantly more risky than its predecessor #17329 Due to file name changes, this PR is expected to change the license files. We haven't rename `shell/gpu` to `shell/raster` yet. It should be optional but I think it's better to have `raster_surface_software.cc` than `gpu_surface_software.cc`.
goderbauer
pushed a commit
to goderbauer/engine
that referenced
this pull request
Apr 16, 2020
This PR touches variable names, class names, and file names so it's significantly more risky than its predecessor flutter#17329 Due to file name changes, this PR is expected to change the license files. We haven't rename `shell/gpu` to `shell/raster` yet. It should be optional but I think it's better to have `raster_surface_software.cc` than `gpu_surface_software.cc`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request should be fairly safe because it only changes comments. I've split the change into several commits for easier checks. We'll rename the actual code variable name, class name, and filename later as those are risky changes.