Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fuchsia] Remove log dumping to prevent timeouts #18409

Merged
merged 1 commit into from
May 15, 2020
Merged

[fuchsia] Remove log dumping to prevent timeouts #18409

merged 1 commit into from
May 15, 2020

Conversation

iskakaushik
Copy link
Contributor

@auto-assign auto-assign bot requested a review from jason-simmons May 15, 2020 02:12
@iskakaushik iskakaushik added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label May 15, 2020
@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Mac Host Engine has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label May 15, 2020
@iskakaushik iskakaushik merged commit d8604b1 into flutter:master May 15, 2020
@iskakaushik iskakaushik deleted the remove-dump-logs branch May 15, 2020 04:10
cbracken
cbracken reviewed May 15, 2020
View reviewed changes
Copy link
Member

@cbracken cbracken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Kaushik!

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request May 16, 2020
@engine-flutter-autoroll
d8604b1 [fuchsia] Remove log dumping to prevent timeouts (flutter/eng…
bd746e2 
…ine#18409)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 16, 2020
Merged
wandyers pushed a commit to wandyers/engine that referenced this pull request May 23, 2020
@iskakaushik @wandyers
[fuchsia] Remove log dumping to prevent timeouts (flutter#18409)
f79c5a6 
See: flutter/flutter#57273
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbracken cbracken cbracken left review comments

@godofredoc godofredoc godofredoc approved these changes

@jason-simmons jason-simmons Awaiting requested review from jason-simmons

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@iskakaushik @fluttergithubbot @cbracken @godofredoc @googlebot