Disconnect the channel message handler when releasing the AccessibilityBridge #18657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Doh, it's the same as #17646. Thanks for fixing. Can we add a similar test? |
|
Added a test |
xster
reviewed
May 29, 2020
| AccessibilityChannel channel = mock(AccessibilityChannel.class); | ||
| AccessibilityBridge accessibilityBridge = | ||
| setUpBridge(null, channel, null, null, null, null); | ||
| verify(channel).setAccessibilityMessageHandler(null); |
There was a problem hiding this comment.
since this is already null, I'd perhaps make this a bit more real by also injecting an AccessibilityManager and let it be isEnabled() true either via mockito or shadowOf(accessibilityManager).setEnabled(true)
xster
reviewed
May 29, 2020
| AccessibilityManager mockManager = mock(AccessibilityManager.class); | ||
| when(mockManager.isEnabled()).thenReturn(true); | ||
| AccessibilityBridge accessibilityBridge = | ||
| setUpBridge(null, mockChannel, mockManager, null, null, null); |
There was a problem hiding this comment.
I meant if you let it be isEnabled, then you can assert that the message handler is non-null before you release, at which point it's then null
There was a problem hiding this comment.
Added a check for the non-null setAccessibilityMessageHandler call done during AccessibilityBridge setup before release is called
xster
approved these changes
May 29, 2020
| AccessibilityManager mockManager = mock(AccessibilityManager.class); | ||
| when(mockManager.isEnabled()).thenReturn(true); | ||
| AccessibilityBridge accessibilityBridge = | ||
| setUpBridge(null, mockChannel, mockManager, null, null, null); |
jason-simmons
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#57661