Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Roll buildroot to 2415cd5095c186fe5054552bbb26aaa2b8877ac8 #19106

Merged
merged 7 commits into from
Jun 18, 2020
Merged

Roll buildroot to 2415cd5095c186fe5054552bbb26aaa2b8877ac8 #19106

merged 7 commits into from
Jun 18, 2020

Conversation

dnfield
Copy link
Contributor

@dnfield dnfield commented Jun 17, 2020 •
edited
Loading

See flutter/buildroot@73cd40a and flutter/buildroot@2415cd5 - primarily deletes unused files and simplifies a couple rules.

Buildroot PR was flutter/buildroot#377 and flutter/buildroot#378

@dnfield dnfield mentioned this pull request Jun 17, 2020
Merged
@dnfield dnfield changed the title Test - do not land. Roll buildroot to 73cd40aa9d6b76aff637267e02fda6f6ce571c41 Jun 18, 2020
@dnfield dnfield marked this pull request as ready for review June 18, 2020 00:11
@dnfield
Copy link
Contributor Author

dnfield commented Jun 18, 2020 •
edited
Loading

Fuchsia failure appears to be a flake, retry here: https://ci.chromium.org/p/flutter/builders/try/Linux%20Fuchsia/10045

failure here:
https://chromium-swarm.appspot.com/task?id=4cdd9a3307049e10

specifically it was the scenic tests that failed:

Adding flutter_runner_scenic_tests...
2020-06-18 00:19:02 [pm serve] 200 /root.json
2020-06-18 00:19:02 [pm serve] 200 /timestamp.json
2020-06-18 00:19:02 [pm serve] 200 /3.snapshot.json
2020-06-18 00:19:02 [pm serve] 200 /3.targets.json
2020-06-18 00:19:02 [pm serve] 200 /blobs/b64887bb088e46524c4a54679211a420ce02085abd6fb0a9deda402fa8d0c2d2
2020-06-18 00:19:05 [pm serve] 200 /blobs/3379b0b4a55976e79785af7bcbe857cd0a730a777c417a9c905fa47f5deeb1eb
Test results (passed: false):
[==========] Running 17 tests from 3 test suites.
[----------] Global test environment set-up.
[----------] 2 tests from SessionConnectionTest
[ RUN      ] SessionConnectionTest.SimplePresentTest
[       OK ] SessionConnectionTest.SimplePresentTest (2038 ms)
[ RUN      ] SessionConnectionTest.BatchedPresentTest

[INFO:test_timeout_listener.cc(76)] Test timeout of 30 seconds per test case will be enforced.
[INFO:vulkan_application.cc(110)] Destroying Vulkan instance
[FATAL:flutter/shell/platform/fuchsia/flutter/tests/session_connection_unittests.cc(80)] Check failed: false.

@godofredoc @gw280 @mikejurka @farchond might know?

goderbauer
goderbauer reviewed Jun 18, 2020
View reviewed changes
DEPS Outdated
@@ -110,7 +110,7 @@ allowed_hosts = [
]

deps = {
'src': 'https://github.com/flutter/buildroot.git' + '@' + 'edf6aa45cbd56aa0bdd9d9333f2ac8e2d29a8be8',
'src': 'https://github.com/flutter/buildroot.git' + '@' + '73cd40aa9d6b76aff637267e02fda6f6ce571c41',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wanna roll this one further to include the last fixes as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@dnfield dnfield changed the title Roll buildroot to 73cd40aa9d6b76aff637267e02fda6f6ce571c41 Roll buildroot to 2415cd5095c186fe5054552bbb26aaa2b8877ac8 Jun 18, 2020
goderbauer
goderbauer approved these changes Jun 18, 2020
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnfield dnfield added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jun 18, 2020
@fluttergithubbot fluttergithubbot merged commit f698526 into master Jun 18, 2020
@dnfield dnfield deleted the dnfield-patch-1 branch June 18, 2020 03:52
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 18, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 18, 2020
@engine-flutter-autoroll
f698526 Roll buildroot to 2415cd5095c186fe5054552bbb26aaa2b8877ac8 (f…
eca6744 
…lutter/engine#19106)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 18, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 18, 2020
@engine-flutter-autoroll
f698526 Roll buildroot to 2415cd5095c186fe5054552bbb26aaa2b8877ac8 (f…
7f8bac3 
…lutter/engine#19106)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 18, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 18, 2020
@engine-flutter-autoroll
f698526 Roll buildroot to 2415cd5095c186fe5054552bbb26aaa2b8877ac8 (f…
910e147 
…lutter/engine#19106)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 18, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 18, 2020
@engine-flutter-autoroll
f698526 Roll buildroot to 2415cd5095c186fe5054552bbb26aaa2b8877ac8 (f…
34dc9bb 
…lutter/engine#19106)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 18, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 18, 2020
@engine-flutter-autoroll
f698526 Roll buildroot to 2415cd5095c186fe5054552bbb26aaa2b8877ac8 (f…
e89798c 
…lutter/engine#19106)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 18, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 18, 2020
@engine-flutter-autoroll
f698526 Roll buildroot to 2415cd5095c186fe5054552bbb26aaa2b8877ac8 (f…
9ea4acd 
…lutter/engine#19106)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Jun 18, 2020
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 18, 2020
@engine-flutter-autoroll
f698526 Roll buildroot to 2415cd5095c186fe5054552bbb26aaa2b8877ac8 (f…
71fecdd 
…lutter/engine#19106)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goderbauer goderbauer goderbauer approved these changes

@stuartmorgan stuartmorgan Awaiting requested review from stuartmorgan

Assignees
No one assigned
Labels
cla: yes waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dnfield @goderbauer @googlebot @fluttergithubbot