-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
send newline char when input type is multiline #20660
send newline char when input type is multiline #20660
Conversation
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
/cc @stuartmorgan |
@stuartmorgan thanks for the very quick review! Hopefully I've fixed all the issues from your feedback. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality looks great, just minor comment nits and then it can be landed. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I'll set the CQ bit once tests have come back green. Thanks for fixing this!
Description
This PR re-instates the functionality for sending a newline char for TextFields on Linux desktop which have a
keyboardType: TextInputType.multiline
set on the widget. This functionality was lost in the move from the GLFW to the new GTK embedding.Related Issues
Fixes: flutter/flutter#62207
Tests
There is no existing test for this, so the regression was not picked up in the move from glfw to gtk. I'm sorry but I don't know how to go about adding a test for this.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
). This will ensure a smooth and quick review process.Breaking Change
Did any tests fail when you ran them? Please read handling breaking changes.