[web] Fix transform not invalidating path bounds causing debugValidate failure #22172

ferhatb · 2020-10-28T18:49:44Z

Description

PathRef startEdit indicates point data is about to be edited. It was not invalidating fBounds on path, this PR marks bounds dirty so that post editing, they can be correctly recomputed.

This bug was causing DDC builds to assert since a call to debugValidate that checks for integrity fails.

Related Issues

flutter/flutter#68702

Tests

Added regression test to path_test.dart

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

I read the [contributor guide] and followed the process outlined there for submitting PRs.
I signed the [CLA].
I read and followed the [C++, Objective-C, Java style guides] for the engine.
I read the [tree hygiene] wiki page, which explains my responsibilities.
I updated/added relevant documentation.
All existing and new tests are passing.
I am willing to follow-up on review comments in a timely manner.

Reviewer Checklist

I have submitted any presubmit flakes in this PR using the [engine presubmit flakes form] before re-triggering the failure.

Breaking Change

Did any tests fail when you ran them? Please read [handling breaking changes].

No, no existing tests failed, so this is not a breaking change.
Yes, this is a breaking change. If not, delete the remainder of this section.
- I wrote a design doc: https://flutter.dev/go/template Replace this with a link to your design doc's short link
- I got input from the developer relations team, specifically from: Replace with the names of who gave advice
- I wrote a migration guide: https://flutter.dev/go/breaking-changes-template Replace this with a link to a pull request that adds the migration guide to https://flutter.dev/docs/release/breaking-changes

ditman · 2020-10-28T20:41:00Z

lib/web_ui/test/path_test.dart

+      Rect bounds = path2.pathRef.getBounds();
+      SurfacePath transformedPath = path2.transform(
+          Matrix4.identity().scaled(0.5, 0.5).toFloat64());
+      expect(bounds != transformedPath.pathRef.getBounds(), isTrue);


Suggested change

expect(bounds != transformedPath.pathRef.getBounds(), isTrue);

expect(transformedPath.pathRef.getBounds(), isNot(bounds));

Instead of a "expected true but was false" test failure, you can get a slightly more explicit error message if you use isNot(equals()) or similar, at least you get the toString of the objects that were being compared :P

Done. Thank you for suggestion!

ditman

RSLGTM!

…gValidate failure (flutter/engine#22172)

* 53d5d68 Add dart-lang/sdk's new package:clock dependency (flutter/engine#22142) * c32e3d8 Roll Skia from 7737a5bd2510 to 5567a6091ceb (8 revisions) (flutter/engine#22146) * 376045c Roll Fuchsia Linux SDK from XYN02FThN... to UKgKCjxSA... (flutter/engine#22147) * 03395de Roll Fuchsia Mac SDK from GKPwGj1Ux... to xHjtLQPQ5... (flutter/engine#22151) * 0c7e952 Manual Dart SDK roll 6e015bd9cddb to 9c6e76468ca4 (6 revisions (flutter/engine#22153) * e5f168a Update constraint to latest integration test (flutter/engine#22169) * e61e8c2 Smooth window resizing on macOS (flutter/engine#21525) * acece00 Allow parse_and_send to use access tokens (flutter/engine#22019) * 0270632 Includes roles for links, checkboxes, and radio buttons in semantics (flutter/engine#22061) * 632354d Roll Fuchsia Linux SDK from UKgKCjxSA... to PY5hNI-wY... (flutter/engine#22175) * 62d50af Add plumbing for command line arguments on Windows (flutter/engine#22094) * 06b0910 Fix possible use of std::moved value in Rasterizer (flutter/engine#22125) * 005dec4 [web] Clean up unused previousStyle logic (flutter/engine#22150) * ca05bdc Roll Skia from 5567a6091ceb to f548a028ce70 (7 revisions) (flutter/engine#22155) * 5b07ac4 Roll Fuchsia Mac SDK from xHjtLQPQ5... to ICK_JlnKJ... (flutter/engine#22188) * d615a97 Roll Fuchsia Linux SDK from PY5hNI-wY... to Usec4YBzR... (flutter/engine#22197) * 11ed711 Invalidate the cached SkParagraph font collection when a new font manager is installed (flutter/engine#22157) * 07c780b [web] Assign default natural width/height for svgs that report 0,0 on firefox and ie11 (flutter/engine#22184) * b54bb88 Migrate runZoned to runZonedGuarded (flutter/engine#22198) * 247139a [web] Fix transform not invalidating path bounds causing debugValidate failure (flutter/engine#22172) * e4dffc1 [web] Fix scroll wheel line delta on Firefox. (flutter/engine#21928) * d6627c6 Reland [ios] Refactor IOSSurface factory and unify surface creation (flutter/engine#22016) * ce1dd11 Standardize macro names for dartdoc macros (flutter/engine#22180) * f81bc37 [profiling] Handle thread_info to account for killed threads (flutter/engine#22170) * fd94c86 Fix for firefox custom clipping (flutter/engine#22182) * 9ccf9f1 bring back build_test to ensure we validate licenses (flutter/engine#22201) * 38f6665 Set strut font to Roboto if the given font hasn't been registered (flutter/engine#22129) * caf32d5 Add a proc table version of embedder API (flutter/engine#21813) * ed0f477 Use preTranslate when applying offset to matrix (flutter/engine#21648) * b457e2d Refactor make_mock_engine into fl_test (flutter/engine#21585) * 28497c8 Fix typos in FlValue docs (flutter/engine#21875) * bb32446 Fix FlTextInputPlugin tear down (flutter/engine#22007) * 7a7804b Add "input shield" to capture pointer input for reinjection (flutter/engine#22067) * fe85f94 Update painting.dart (flutter/engine#22195) * 99cc50d [ios] Surface factory holds the canonical reference to the external view embedder (flutter/engine#22206)

…gValidate failure (flutter/engine#22172)

…e failure (flutter#22172)

Fix transform not invalidating path bounds causing debugValidate failure

0087911

ferhatb requested review from yjbanov and ditman October 28, 2020 18:49

googlebot added the cla: yes label Oct 28, 2020

ditman reviewed Oct 28, 2020

View reviewed changes

ferhatb added 3 commits October 28, 2020 13:58

address reviewer comment

2294e2d

Merge remote-tracking branch 'upstream/master' into unstable_path

a8d8789

Merge remote-tracking branch 'upstream/master' into unstable_path

933034a

ferhatb added the platform-web Code specifically for the web engine label Oct 29, 2020

ditman approved these changes Oct 29, 2020

View reviewed changes

ferhatb merged commit 247139a into flutter:master Oct 29, 2020

engine-flutter-autoroll mentioned this pull request Oct 29, 2020

Roll Engine from 073263e39d1d to e4dffc107032 (21 revisions) flutter/flutter#69331

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 29, 2020

247139a [web] Fix transform not invalidating path bounds causing debu…

b2177e3

…gValidate failure (flutter/engine#22172)

engine-flutter-autoroll mentioned this pull request Oct 29, 2020

Roll Engine from 073263e39d1d to 9ccf9f120ddc (26 revisions) flutter/flutter#69335

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 29, 2020

247139a [web] Fix transform not invalidating path bounds causing debu…

db2cf09

…gValidate failure (flutter/engine#22172)

engine-flutter-autoroll mentioned this pull request Oct 29, 2020

Roll Engine from 073263e39d1d to fe85f946db04 (34 revisions) flutter/flutter#69343

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 29, 2020

247139a [web] Fix transform not invalidating path bounds causing debu…

9150dc1

…gValidate failure (flutter/engine#22172)

GaryQian mentioned this pull request Oct 29, 2020

Roll engine from 073263e39d1d to fe85f946db04 (34 revisions) manual flutter/flutter#69347

Closed

engine-flutter-autoroll mentioned this pull request Oct 29, 2020

Roll Engine from 073263e39d1d to fe85f946db04 (34 revisions) flutter/flutter#69349

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 29, 2020

247139a [web] Fix transform not invalidating path bounds causing debu…

68735f4

…gValidate failure (flutter/engine#22172)

engine-flutter-autoroll mentioned this pull request Oct 30, 2020

Roll Engine from 073263e39d1d to 99cc50dfffab (35 revisions) flutter/flutter#69353

Merged

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 30, 2020

247139a [web] Fix transform not invalidating path bounds causing debu…

46beeb2

…gValidate failure (flutter/engine#22172)

engine-flutter-autoroll mentioned this pull request Oct 30, 2020

Roll Engine from 073263e39d1d to 7d6180c3014a (37 revisions) flutter/flutter#69357

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 30, 2020

247139a [web] Fix transform not invalidating path bounds causing debu…

1d14c58

…gValidate failure (flutter/engine#22172)

engine-flutter-autoroll mentioned this pull request Oct 30, 2020

Roll Engine from 99cc50dfffab1 to 7d6180c3014a (2 revisions) flutter/flutter#69365

Closed

engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 30, 2020

247139a [web] Fix transform not invalidating path bounds causing debu…

e8a892c

…gValidate failure (flutter/engine#22172)

chaselatta pushed a commit to chaselatta/engine that referenced this pull request Nov 30, 2020

[web] Fix transform not invalidating path bounds causing debugValidat…

5311660

…e failure (flutter#22172)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[web] Fix transform not invalidating path bounds causing debugValidate failure #22172

[web] Fix transform not invalidating path bounds causing debugValidate failure #22172

ferhatb commented Oct 28, 2020

ditman Oct 28, 2020

ferhatb Oct 28, 2020

ditman left a comment

	expect(bounds != transformedPath.pathRef.getBounds(), isTrue);
	expect(transformedPath.pathRef.getBounds(), isNot(bounds));

[web] Fix transform not invalidating path bounds causing debugValidate failure #22172

[web] Fix transform not invalidating path bounds causing debugValidate failure #22172

Conversation

ferhatb commented Oct 28, 2020

Description

Related Issues

Tests

Checklist

Reviewer Checklist

Breaking Change

ditman Oct 28, 2020

Choose a reason for hiding this comment

ferhatb Oct 28, 2020

Choose a reason for hiding this comment

ditman left a comment

Choose a reason for hiding this comment