Implement pushColorFilter in CanvasKit #22838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I could also wait for the SkPicture resurrection PR to land and add a golden test for this. |
yjbanov
approved these changes
Dec 3, 2020
| @@ -49,6 +49,17 @@ void testMain() { | |||
| final ui.Image sceneImage = await scene.toImage(100, 100); | |||
| expect(sceneImage, isA<CkImage>()); | |||
| }); | |||
| // TODO: https://github.com/flutter/flutter/issues/60040 | |||
|
|
|||
| test('pushColorFilter does not throw', () async { | |||
There was a problem hiding this comment.
Bonus points for making it a screenshot test. To do that, simply rename the file to scene_golden_test.dart and use golden_tester.dart like normal (example).
There was a problem hiding this comment.
although the test would need to be skipped outside chrome.
|
Can we land this? |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 14, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 14, 2020
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Dec 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements
pushColorFilterinui.SceneBuilderin CanvasKit.Related Issues
Fixes the following issues in CanvasKit mode:
Fixes flutter/flutter#71733
Tests
I added the following tests:
Added a test to
scene_test.dartChecklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.Reviewer Checklist
Breaking Change
Did any tests fail when you ran them? Please read handling breaking changes.