iOS: Drain and pass URLRequest body data to the platform implementation #2286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes flutter/flutter#1343 |
| // If the body has request data, try to drain that | ||
| AsyncNSDataDrainer::Drain( | ||
| request->body[0].Pass(), // handle | ||
| base::Bind(&URLLoaderImpl::StartNow, base::Unretained(this), |
There was a problem hiding this comment.
This lifetimes here are slightly sketchy. In particular, this can die before the drain is finished and you'll get a callback call with a bogus this pointer. You've got two choices for how to resolve this issue:
- Have this object hold the AsyncNSDataDrainer as a member, similar to how AsyncNSDataDrainer holds common::DataPipeDrainer. Then when this object dies, it will kill the AsyncNSDataDrainer, which will kill the common::DataPipeDrainer and stop the callbacks.
- Instead of using
base::Unretained(this)here, you can bind abase::WeakPtrto the callback. The callback will check the weak pointer before using it as the "this" pointer.
I'd recommend (1) because the WeakPtr approach doesn't stop the drain when the client goes away.
|
LGTM w/ lifetime issue fixed. |
|
|
||
| void OnDataComplete() override { | ||
| auto callback = callback_; | ||
| auto data = data_; |
There was a problem hiding this comment.
I would put the type in here explicitly because it's important that its an NSMutableData* rather than a NSMutableData*&, for example.
|
LGTM |
|
Done. Rebased. |
chinmaygarde
added a commit
that referenced
this pull request
Jan 25, 2016
iOS: Drain and pass URLRequest body data to the platform implementation
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
Since enum values listed on the enum class's page are, I think, the only case of multiple paragraphs inside a dd, they deserve some special styling.
rhencke
pushed a commit
to rhencke/engine
that referenced
this pull request
Dec 20, 2020
Removing make and automake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.