Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make internal BSTR private in ScopedBstr #25096

Merged
merged 1 commit into from
Mar 19, 2021
Merged

Make internal BSTR private in ScopedBstr #25096

merged 1 commit into from
Mar 19, 2021

Conversation

cbracken
Copy link
Member

There are no subclasses of this class in our codebase that would
necessitate a protected member.

Internal visibility cleanup, covered by existing build/test.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@cbracken
Make internal BSTR private in ScopedBstr
ea879bc 
There are no subclasses of this class in our codebase that would
necessitate a protected member.
@google-cla google-cla bot added the cla: yes label Mar 19, 2021
chunhtai
chunhtai approved these changes Mar 19, 2021
View reviewed changes
Copy link
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbracken cbracken merged commit 94e43ee into flutter:master Mar 19, 2021
@cbracken cbracken deleted the scoped-bstr-private branch March 19, 2021 16:28
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 19, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 19, 2021
@engine-flutter-autoroll
94e43ee Make internal BSTR private in ScopedBstr (flutter/engine#25096)
c602084
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 20, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 20, 2021
@engine-flutter-autoroll
94e43ee Make internal BSTR private in ScopedBstr (flutter/engine#25096)
5641e72
@clarkezone
Copy link
Contributor

LGTM belatedly

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 20, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 20, 2021
@engine-flutter-autoroll
94e43ee Make internal BSTR private in ScopedBstr (flutter/engine#25096)
e2fef52
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 20, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 20, 2021
@engine-flutter-autoroll
94e43ee Make internal BSTR private in ScopedBstr (flutter/engine#25096)
f70362d
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 20, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 20, 2021
@engine-flutter-autoroll
94e43ee Make internal BSTR private in ScopedBstr (flutter/engine#25096)
c92a60e
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 22, 2021
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 22, 2021
@engine-flutter-autoroll
94e43ee Make internal BSTR private in ScopedBstr (flutter/engine#25096)
9fcf237
hjfreyer pushed a commit to hjfreyer/engine that referenced this pull request Mar 22, 2021
@cbracken @hjfreyer
Make internal BSTR private in ScopedBstr (flutter#25096)
a7d075e 
There are no subclasses of this class in our codebase that would
necessitate a protected member.
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Mar 22, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Mar 22, 2021
@engine-flutter-autoroll
94e43ee Make internal BSTR private in ScopedBstr (flutter/engine#25096)
5f473ce
chriscraws pushed a commit to chriscraws/engine that referenced this pull request Mar 23, 2021
@cbracken @chriscraws
Make internal BSTR private in ScopedBstr (flutter#25096)
25241a4 
There are no subclasses of this class in our codebase that would
necessitate a protected member.
duanqz pushed a commit to duanqz/engine that referenced this pull request Apr 16, 2021
@cbracken @duanqz
Make internal BSTR private in ScopedBstr (flutter#25096)
59c6196 
There are no subclasses of this class in our codebase that would
necessitate a protected member.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chunhtai chunhtai chunhtai approved these changes

@clarkezone clarkezone Awaiting requested review from clarkezone

@gw280 gw280 Awaiting requested review from gw280

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cbracken @clarkezone @chunhtai