-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Engine] Support for Android Fullscreen Modes #25785
Conversation
This pull request is not mergeable in its current state, likely because of a merge conflict. Pre-submit CI jobs were not triggered. Pushing a new commit to this branch that resolves the issue will result in pre-submit jobs being scheduled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code itself looks good to me! However, I'm less familiar with the engine side of things and am unsure how testing works. @gaaclarke could you help out with this PR or redirect to someone who might be more appropriate? Thank you!
shell/platform/android/io/flutter/embedding/engine/systemchannels/PlatformChannel.java
Show resolved
Hide resolved
shell/platform/android/io/flutter/plugin/platform/PlatformPlugin.java
Outdated
Show resolved
Hide resolved
cc @blasten Can you please redirect this to the appropriate reviewer so @shihaohong s concerns are addressed please? |
This pull request is not suitable for automatic merging in its current state.
|
flutter#27014) This reverts commit f04d204.
flutter#27014) This reverts commit f04d204.
This pull request was opened against a branch other than main. Since Flutter pull requests should not normally be opened against branches other than main, I have changed the base to main. If this was intended, you may modify the base back to master. See the Release Process for information about how other branches get updated. Reviewers: Use caution before merging pull requests to branches other than main, unless this is an intentional hotfix/cherrypick. |
1 similar comment
This pull request was opened against a branch other than main. Since Flutter pull requests should not normally be opened against branches other than main, I have changed the base to main. If this was intended, you may modify the base back to master. See the Release Process for information about how other branches get updated. Reviewers: Use caution before merging pull requests to branches other than main, unless this is an intentional hotfix/cherrypick. |
This adds support for Android fullscreen modes.
Framework side: flutter/flutter#81303
Related Issues:
Pre-launch Checklist
writing and running engine tests.
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.