Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Engine] Support for Android Fullscreen Modes #25785

Merged
merged 31 commits into from
Jun 24, 2021

Conversation

Piinks
Copy link
Contributor

@Piinks Piinks commented Apr 27, 2021

This adds support for Android fullscreen modes.

Framework side: flutter/flutter#81303

Related Issues:

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.
  • The reviewer has submitted any presubmit flakes in this PR using the engine presubmit flakes form before re-triggering the failure.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label Apr 27, 2021
@Piinks Piinks changed the title [WIP] Android fullscreen support [WIP/Engine] Support for Android Fullscreen Modes Apr 27, 2021
@Piinks Piinks changed the title [WIP/Engine] Support for Android Fullscreen Modes Support for Android Fullscreen Modes Jun 8, 2021
@Piinks Piinks changed the title Support for Android Fullscreen Modes [Engine] Support for Android Fullscreen Modes Jun 8, 2021
@Piinks Piinks marked this pull request as ready for review June 8, 2021 21:32
@flutter-dashboard
Copy link

This pull request is not mergeable in its current state, likely because of a merge conflict. Pre-submit CI jobs were not triggered. Pushing a new commit to this branch that resolves the issue will result in pre-submit jobs being scheduled.

Copy link

@shihaohong shihaohong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code itself looks good to me! However, I'm less familiar with the engine side of things and am unsure how testing works. @gaaclarke could you help out with this PR or redirect to someone who might be more appropriate? Thank you!

@chinmaygarde
Copy link
Member

cc @blasten Can you please redirect this to the appropriate reviewer so @shihaohong s concerns are addressed please?

@blasten blasten requested a review from GaryQian June 17, 2021 22:02
@Piinks Piinks added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jun 23, 2021
@Piinks Piinks removed the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jun 23, 2021
@Piinks Piinks added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jun 23, 2021
@fluttergithubbot
Copy link
Contributor

This pull request is not suitable for automatic merging in its current state.

  • The status or check suite Linux Unopt has failed. Please fix the issues identified (or deflake) before re-applying this label.

@fluttergithubbot fluttergithubbot removed the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jun 24, 2021
@Piinks Piinks added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jun 24, 2021
@fluttergithubbot fluttergithubbot merged commit f04d204 into flutter:master Jun 24, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 24, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 24, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 24, 2021
angjieli added a commit that referenced this pull request Jun 28, 2021
zanderso pushed a commit that referenced this pull request Jun 28, 2021
@Piinks Piinks mentioned this pull request Jun 28, 2021
9 tasks
moffatman pushed a commit to moffatman/engine that referenced this pull request Aug 5, 2021
moffatman pushed a commit to moffatman/engine that referenced this pull request Aug 5, 2021
naudzghebre pushed a commit to naudzghebre/engine that referenced this pull request Sep 2, 2021
naudzghebre pushed a commit to naudzghebre/engine that referenced this pull request Sep 2, 2021
@flutter-dashboard
Copy link

This pull request was opened against a branch other than main. Since Flutter pull requests should not normally be opened against branches other than main, I have changed the base to main. If this was intended, you may modify the base back to master. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than main, unless this is an intentional hotfix/cherrypick.

1 similar comment
@flutter-dashboard
Copy link

This pull request was opened against a branch other than main. Since Flutter pull requests should not normally be opened against branches other than main, I have changed the base to main. If this was intended, you may modify the base back to master. See the Release Process for information about how other branches get updated.

Reviewers: Use caution before merging pull requests to branches other than main, unless this is an intentional hotfix/cherrypick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes platform-android platform-fuchsia platform-ios waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants