plumb frame number through to framework #26233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flutter-dashboard
bot
added
the
platform-web
jonahwilliams
commented
May 18, 2021
common/settings.h
Outdated
| @@ -40,8 +40,14 @@ class FrameTiming { | |||
| return data_[phase] = value; | |||
| } | |||
|
|
|||
| int64_t GetFrameNumber() const { return frame_number_; } | |||
There was a problem hiding this comment.
ahh this should probably be unsigned, will update
…engine into frame_timing_frame_number
jonahwilliams
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 19, 2021
fluttergithubbot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The engine side work of flutter/flutter#80735
This allows events sent by the framework to be easily matched with the corresponding engine side events.