Add support for native callbacks to the macOS embedder test harness #26694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chinmaygarde
approved these changes
Jun 10, 2021
There was a problem hiding this comment.
I have mixed feelings about this since we are using private APIs to setup the native entrypoints. Since this is just a test target and uses existing test infrastructure to so, I suppose we can followup on switching over the entire mechanism to FFI in the future. Can you file a bug for this please? In the meantime, LGTM on this.
|
Filed flutter/flutter#84379 |
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 11, 2021
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Jun 11, 2021
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Jun 11, 2021
* 7d9e74b Roll Fuchsia Mac SDK from jNlbyBr6p... to OP_AFyX5C... (flutter/engine#26701) * 2aca204 Roll Skia from 08ac524b4331 to 2a07fd68ebdd (1 revision) (flutter/engine#26702) * 1428214 Roll Dart SDK from d622b98e77d7 to c8a66f8e7ca1 (1 revision) (flutter/engine#26703) * f3c565a Roll Skia from 2a07fd68ebdd to dd84dd09f304 (2 revisions) (flutter/engine#26704) * 27e512b Roll Skia from dd84dd09f304 to bc215ba3bbfe (2 revisions) (flutter/engine#26706) * 5e02b82 Add support for native callbacks to the macOS embedder test harness (flutter/engine#26694) * 6ddc148 Roll Dart SDK from c8a66f8e7ca1 to 935470ea59c4 (1 revision) (flutter/engine#26707) * 3b80c93 Roll Skia from bc215ba3bbfe to 1907f9051e17 (1 revision) (flutter/engine#26708) * 252ad2b [web] text_editing_test.dart nnbd; bump test dep (flutter/engine#26709) * 2b57326 Revert dart rolls (flutter/engine#26714) * 201ee6f Roll Skia from 1907f9051e17 to 9b0841d822c3 (1 revision) (flutter/engine#26713)
naudzghebre
pushed a commit
to naudzghebre/engine
that referenced
this pull request
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reland of #26623 without erroneous
FlutterEngineTestContext.mmfile.That file was accidentally included in the last PR which didn't break any pre/post-submits due to it not being built, but its presence caused test failures later on after rolling. This PR is the same as the previous one but without that file.