Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Surface frame number identifier through window #26785

Merged

Conversation

jonahwilliams
Copy link
Member

Allows the frame work to access the current frame number. This allows us to implement frame specific debug information tracking for flutter/flutter#80748

@google-cla google-cla bot added the cla: yes label Jun 16, 2021
@jonahwilliams jonahwilliams marked this pull request as ready for review June 16, 2021 21:37
@flutter-dashboard flutter-dashboard bot added the platform-web Code specifically for the web engine label Jun 16, 2021
Copy link
Contributor

@iskakaushik iskakaushik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jonahwilliams
Copy link
Member Author

Need to do some more updates for the unit tests

@jonahwilliams jonahwilliams added the Work in progress (WIP) Not ready (yet) for review! label Jun 26, 2021
@jonahwilliams jonahwilliams removed the Work in progress (WIP) Not ready (yet) for review! label Jun 28, 2021
@jonahwilliams
Copy link
Member Author

I'm technically OOO but will mark this to be merged so its ready when I get back 😅 .

@jonahwilliams jonahwilliams added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jun 28, 2021
@fluttergithubbot fluttergithubbot merged commit 360d2d8 into flutter:master Jun 28, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jun 29, 2021
zanderso pushed a commit to flutter/flutter that referenced this pull request Jun 29, 2021
* ce489a5 Roll Skia from 0f1ac21185fe to b1590f15a32b (1 revision) (flutter/engine#27000)

* 92e24d8 Record raster end as soon as frame is submitted (flutter/engine#26970)

* 1f35cce Remove presubmit flake reporting instructions from issue template. (flutter/engine#26997)

* f5bc55e Roll Skia from b1590f15a32b to eef5b0e933e3 (2 revisions) (flutter/engine#27001)

* 8f57dfe Roll Fuchsia Mac SDK from z6trYeCMx... to R1ENSI-od... (flutter/engine#27002)

* 360d2d8 Surface frame number identifier through window (flutter/engine#26785)

* ed87f7c Roll Dart SDK from d2025958e351 to eca780278d49 (1 revision) (flutter/engine#27003)

* f558e2a Roll Fuchsia Linux SDK from TqViQQzJo... to 4udsaggtH... (flutter/engine#27006)

* 8ae3ff7 Fix Fuchsia build on Mac (flutter/engine#27007)

* b259ea6 Revert "[Engine] Support for Android Fullscreen Modes (#25785)" (flutter/engine#27014)

* 6e105c9 Roll Skia from eef5b0e933e3 to e5766b808045 (12 revisions) (flutter/engine#27011)

* cfea27e Allow fuchsia_archive to accept a cml file and cmx file (flutter/engine#27012)

* 9ef94a2 [web] Librarify paragraph/text files (flutter/engine#26888)

* cc2c361 Roll Dart SDK from eca780278d49 to bbd701b4ba76 (1 revision) (flutter/engine#27015)

* f6fcab4 Roll CanvasKit to 0.28.1 (flutter/engine#27013)

* db8ed9e Configure contexts to reduce shader variations. (flutter/engine#27016)

* 94876ed Roll Skia from e5766b808045 to 661abd0f8d64 (7 revisions) (flutter/engine#27020)

* 35e297d Update ci.yaml documentation link (flutter/engine#26922)

* 6a87e0b [web] fix actions flags in SemanticsTester (flutter/engine#26992)

* 53ac32f Re-land Android fullscreen support (flutter/engine#27018)

* 1417a82 [web] make analysis options delta of root options (flutter/engine#26991)

* b84ebe5 Roll Skia from 661abd0f8d64 to 1bddd42b9897 (3 revisions) (flutter/engine#27023)

* 4f3d88e [web] Librarify keyboard files (flutter/engine#26917)

* 9d09594 Roll Dart SDK from bbd701b4ba76 to fff3a3747a18 (1 revision) (flutter/engine#27024)
moffatman pushed a commit to moffatman/engine that referenced this pull request Aug 5, 2021
naudzghebre pushed a commit to naudzghebre/engine that referenced this pull request Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes platform-web Code specifically for the web engine waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
3 participants