Fix dart analysis #27367
Fix dart analysis #27367
Conversation
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact Hixie on the #hackers channel in Chat. If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
lib/ui/semantics.dart
Outdated
| final TextRange range; | ||
|
|
||
| // Returns a copy of this atttribute with the given range. | ||
| /// Returns a copy of this atttribute with the given range. |
There was a problem hiding this comment.
// is appropriate here since as written this is not adequate documentation.
There was a problem hiding this comment.
Then we need to update the text, because this fails analysis requiring public members be documented.
There was a problem hiding this comment.
@chunhtai @goderbauer - I've updated the text here, PTAL to make sure it makes sense.
| bindings_output_dir = "$root_gen_dir/sky/bindings" | ||
|
|
||
| copy("generate_dart_ui") { | ||
| # TODO(dnfield): Remove this when recipes are updated to not use it. |
There was a problem hiding this comment.
which recipes are this refering to? Can you also file an issue for this?
There was a problem hiding this comment.
There was a problem hiding this comment.
Let's include the link in the todo so we know when to clean up this once it merges
|
test-exempt: is a test |
| @@ -662,10 +662,10 @@ abstract class StringAttribute extends NativeFieldWrapperClass1 { | |||
| required this.range, | |||
| }); | |||
|
|
|||
| // The range of the text to which this attribute applies. | |||
| /// The range of the text to which this attribute applies. | |||
There was a problem hiding this comment.
oops thanks for fixing this
dnfield
force-pushed
the
fix_dart_analysis
branch
from
39a2c0c
to
9b1072e
Compare
|
This PR mistakenly contained changes from another branch I'm working on - I've reverted that. |
| /// For example, the [LocaleStringAttribute] specifies a [Locale] for its | ||
| /// range of characters. Copying it will result in a new | ||
| /// [LocaleStringAttribute] that has the same locale but an updated | ||
| /// [TextRange]. |
There was a problem hiding this comment.
This doc looks good to me
dnfield
added
the
waiting for tree to go green
the generate_dart_ui target is redundant with the sky_engine target.
We should just point the analyzer to that one to avoid the extra file copies.
For reasons I do not understand, analyzing the generate_dart_ui target fails to catch some doc-comments missing in semantics.dart, but catches them correctly in the updated location.
I'm making
generate_dart_uian empty target until we can remove references from it in CI.