Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci_yaml] Add autoroller builder #27731

Merged
merged 3 commits into from
Jul 28, 2021

Conversation

CaseyHillers
Copy link
Contributor

flutter/flutter#84998

Pre-launch Checklist

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • I read the [Tree Hygiene] wiki page, which explains my responsibilities.
  • I read and followed the [Flutter Style Guide] and the [C++, Objective-C, Java style guides].
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See [testing the engine] for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the [CLA].
  • All existing and new tests are passing.

Copy link
Member

@christopherfujino christopherfujino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CaseyHillers
Copy link
Contributor Author

@CaseyHillers CaseyHillers added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Jul 28, 2021
@CaseyHillers CaseyHillers merged commit ce61638 into flutter:master Jul 28, 2021
@CaseyHillers CaseyHillers deleted the ci-yaml-roller branch July 28, 2021 16:29
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 28, 2021
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Jul 28, 2021
@@ -319,3 +319,10 @@ targets:
jazzy_version: 0.9.5
timeout: 90
scheduler: luci

- name: Linux ci_yaml engine roller
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we add a run_if? Run this builder only when .ci.yaml changes. This way no bot resource is needed for most PRs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is postsubmit only, and we currently do not support run_if on prod tasks. This is using linux vms so it shouldn't be expensive.

naudzghebre pushed a commit to naudzghebre/engine that referenced this pull request Sep 2, 2021
filmil pushed a commit to filmil/engine that referenced this pull request Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants