Fix regression in system UI colors #28206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blasten
reviewed
Aug 19, 2021
blasten
reviewed
Aug 19, 2021
| if (systemChromeStyle.statusBarIconBrightness != null) { | ||
| switch (systemChromeStyle.statusBarIconBrightness) { | ||
| case DARK: | ||
| // View.SYSTEM_UI_FLAG_LIGHT_STATUS_BAR |
There was a problem hiding this comment.
This value was deprecated in API 30.
Do we know if this still works in Build.VERSION.SDK_INT >= 30 ?
There was a problem hiding this comment.
Yeah, the migration should probably be in a separate change though so all of this file can be migrated.
blasten
reviewed
Aug 19, 2021
| if (systemChromeStyle.systemNavigationBarIconBrightness != null) { | ||
| switch (systemChromeStyle.systemNavigationBarIconBrightness) { | ||
| case DARK: | ||
| // View.SYSTEM_UI_FLAG_LIGHT_NAVIGATION_BAR |
Piinks
added
the
waiting for tree to go green
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Aug 20, 2021
zanderso
pushed a commit
to flutter/flutter
that referenced
this pull request
Aug 20, 2021
* 53bc600 Fix regression in system UI colors (flutter/engine#28206) * b423776 Roll Dart SDK from bc7cf49acc5c to 0f5cc29e104b (1 revision) (flutter/engine#28210) * 6057453 Revert "Roll Fuchsia Mac SDK from 9xK8HkMEI... to EZSVwdQoz... (#28200)" (flutter/engine#28214) * 17ddfb3 Revert "Roll Fuchsia Linux SDK from ZSqn1OAt7... to czYvw1Rk3... (#28201)" (flutter/engine#28213)
chriscraws
pushed a commit
to chriscraws/engine
that referenced
this pull request
Aug 23, 2021
christopherfujino
pushed a commit
to christopherfujino/engine
that referenced
this pull request
Sep 1, 2021
christopherfujino
added a commit
that referenced
this pull request
Sep 2, 2021
) * 'Update Dart SDK to aa7d19d' * [web] Don't reset history on hot restart (#27872) * Makes scrollable to use main screen if the flutter view is not attached to a screen (#28110) * Fix regression in system UI colors (#28206) * update licenses golden Co-authored-by: Mouad Debbar <mouad.debbar@gmail.com> Co-authored-by: chunhtai <47866232+chunhtai@users.noreply.github.com> Co-authored-by: Kate Lovett <katelovett@google.com>
tneotia
pushed a commit
to BlueBubblesApp/engine
that referenced
this pull request
Dec 9, 2021
…tter#28415) * 'Update Dart SDK to aa7d19d' * [web] Don't reset history on hot restart (flutter#27872) * Makes scrollable to use main screen if the flutter view is not attached to a screen (flutter#28110) * Fix regression in system UI colors (flutter#28206) * update licenses golden Co-authored-by: Mouad Debbar <mouad.debbar@gmail.com> Co-authored-by: chunhtai <47866232+chunhtai@users.noreply.github.com> Co-authored-by: Kate Lovett <katelovett@google.com>
filmil
pushed a commit
to filmil/engine
that referenced
this pull request
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#88431
This fixes a regression introduced in #27018. The refactored style portion made color changes dependent on brightness not being null.
Pre-launch Checklist
writing and running engine tests.
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.