Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed android unit tests (rotted before CI is running) #28938

Merged
merged 1 commit into from
Sep 29, 2021
Merged

fixed android unit tests (rotted before CI is running) #28938

merged 1 commit into from
Sep 29, 2021

Conversation

gaaclarke
Copy link
Member

@gaaclarke gaaclarke commented Sep 29, 2021 •
edited
Loading

This code atrophied before I could get CI running.

issue: flutter/flutter#90903

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@google-cla google-cla bot added the cla: yes label Sep 29, 2021
@gaaclarke gaaclarke added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Sep 29, 2021
@gaaclarke gaaclarke merged commit 2a2e116 into flutter:master Sep 29, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Sep 29, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Sep 29, 2021
@engine-flutter-autoroll
2a2e116 fixed android unit tests (rotted before CI is running) (flutt…
0a11450 
…er/engine#28938)
akbiggs pushed a commit to akbiggs/engine that referenced this pull request Oct 1, 2021
@gaaclarke @akbiggs
fixed android unit tests (rotted before CI is running) (flutter#28938)
f0a0581
dnfield pushed a commit to dnfield/engine that referenced this pull request Oct 6, 2021
@gaaclarke @dnfield
fixed android unit tests (rotted before CI is running) (flutter#28938)
3210e2c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jason-simmons jason-simmons jason-simmons approved these changes

@blasten blasten Awaiting requested review from blasten

Assignees
No one assigned
Labels
cla: yes platform-android waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaaclarke @jason-simmons