-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use accessibility_config for accessibility/ax #29275
Conversation
//flutter/third_party/accessiblity/ax/ax_event_generator.cc includes the AXEventGenerator::Iterator class which subclasses std::iterator, which triggers an MSVC C++17 deprecation warning. This warning, can be suppressed by defining _SILENCE_CXX17_ITERATOR_BASE_CLASS_DEPRECATION_WARNING which is already done in the accessibility_config config. Also updates the TODO to reference the issue tracking the cleanup and removal of that definition. Issue: flutter/flutter#92229
"//flutter/shell/platform/common:common_cpp_accessibility", | ||
"//flutter/third_party/accessibility/*", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this just a more fragile way of writing :*
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:*
selects just the targets within this package, but /*
selects sub-packages as well -- in this case targets in the ax
subdirectory. As an alternative, I could select just that one subdirectory in addition to :*
.
//flutter/third_party/accessiblity/ax/ax_event_generator.cc includes the AXEventGenerator::Iterator class which subclasses std::iterator, which triggers an MSVC C++17 deprecation warning. This warning, can be suppressed by defining _SILENCE_CXX17_ITERATOR_BASE_CLASS_DEPRECATION_WARNING which is already done in the accessibility_config config. Also updates the TODO to reference the issue tracking the cleanup and removal of that definition. Issue: flutter/flutter#92229
//flutter/third_party/accessiblity/ax/ax_event_generator.cc includes the
AXEventGenerator::Iterator class which subclasses std::iterator, which
triggers an MSVC C++17 deprecation warning. This warning, can be
suppressed by defining _SILENCE_CXX17_ITERATOR_BASE_CLASS_DEPRECATION_WARNING
which is already done in the accessibility_config config.
Also updates the TODO to reference the issue tracking the cleanup and
removal of that definition.
Issue: flutter/flutter#92229
Issue: flutter/flutter#77838
This is pre-factoring for an upcoming a11y patch.
No tests added since no code is changed.
Pre-launch Checklist
writing and running engine tests.
///
).If you need help, consider asking for advice on the #hackers-new channel on Discord.