Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove deprecated scripts from engine. #29365

Merged
merged 1 commit into from
Oct 27, 2021
Merged

Remove deprecated scripts from engine. #29365

merged 1 commit into from
Oct 27, 2021

Conversation

godofredoc
Copy link
Contributor

We are doing cleanup of unused scripts as part of preparing the engine
repository to migrate from master to main branch.

Bug: flutter/flutter#90476

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • I added new tests to check the change I am making or feature I am adding, or Hixie said the PR is test-exempt. See testing the engine for instructions on
    writing and running engine tests.
  • I updated/added relevant documentation (doc comments with ///).
  • I signed the CLA.
  • All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@godofredoc
Remove deprecated scripts from engine.
72a5290 
We are doing cleanup of unused scripts as part of preparing the engine
repository to migrate from master to main branch.

Bug: flutter/flutter#90476
@google-cla google-cla bot added the cla: yes label Oct 27, 2021
gspencergoog
gspencergoog approved these changes Oct 27, 2021
View reviewed changes
Copy link
Contributor

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@godofredoc godofredoc added the waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land. label Oct 27, 2021
@fluttergithubbot fluttergithubbot merged commit bb173be into flutter:master Oct 27, 2021
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 27, 2021
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/flutter that referenced this pull request Oct 27, 2021
@engine-flutter-autoroll
bb173be Remove deprecated scripts from engine. (flutter/engine#29365)
06e6343
@godofredoc godofredoc deleted the remove_dep_scripts branch December 1, 2021 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanderso zanderso zanderso approved these changes

@gspencergoog gspencergoog gspencergoog approved these changes

Assignees
No one assigned
Labels
cla: yes waiting for tree to go green This PR is approved and tested, but waiting for the tree to be green to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@godofredoc @zanderso @gspencergoog @fluttergithubbot